Bug 743029

Summary:	Deleting group in WebUI doesn't log adequately
Product:	[Retired] Beaker	Reporter:	Derrich Hafemann <dhafeman>
Component:	web UI	Assignee:	Raymond Mancy <rmancy>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	0.7	CC:	bpeck, dcallagh, ebaak, mcsontos, mschick, rmancy, stl
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-04-16 03:01:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Derrich Hafemann 2011-10-03 16:05:01 UTC

Description of problem:

When deleting a group in the Beaker WebUI, the activity logging isn't as detailed as it ought to be.

How reproducible: 100%


Steps to Reproduce:
1. Create group in Beaker. I called mine 'dummy'. I added a single (broken) system to it, and two users (dhafeman, gbrirner)
2. After creating group, click 'Delete'.
3. The group is deleted. In the activity log, there's a single line stating that the group was deleted - but unless you have a recent database backup to restore from and inspect, there's no way to determine what systems or users were members of the deleted group.

   
Actual results: There's a single line in the activity log stating that the group was deleted.


Expected results: There should be more data logged when a group is deleted - at a minimum, which systems and users belonged to the group should be recorded.

Comment 2 Raymond Mancy 2012-03-15 03:17:10 UTC

What's the purpose of this feature?
Is it in case a group is accidentally deleted and it needs to be rebuilt?

For a couple of reasons, I'm not sure if Activity row is necessarily the right place to keep this data.

Could we just send an email with the group details (maybe that's a bit random..)? If possible I'd like to make the code change for this as simple as possible, if it's a very small corner case.

Comment 3 Raymond Mancy 2012-03-15 03:28:36 UTC

Ok so if we start recording meta group activitiy, then we should probably do it properly and record all facets of change.

Comment 4 Raymond Mancy 2012-04-12 03:14:14 UTC

Sorry, meant to push this back to 0.8.3 earlier

Comment 5 Raymond Mancy 2012-04-16 03:01:17 UTC

We currently have a GroupActivity. You'd think we should log the deletion of a group here. This doesn't work though, as the group is actually deleted. The solution is to just mark the group as deleted and then deal with the consequences of that in various places throughout the code. This is not overly simple though.

This RFE seems to be more about dealing with the consequences of a mistakes (of which there are other alternatives), rather than actually being a real enhancing feature that is often used.