Bug 743262

Summary: empty column header in decision table throws NPE
Product: [JBoss] JBoss Enterprise BRMS Platform 5 Reporter: Jiri Svitak <jsvitak>
Component: BRE (Expert, Fusion)Assignee: Nobody <nobody>
Status: VERIFIED --- QA Contact: Marek Baluch <mbaluch>
Severity: medium Docs Contact:
Priority: unspecified    
Version: BRMS 5.2.0.GACC: mbaluch
Target Milestone: ---   
Target Release: BRMS 5.3.0.GA   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Previously including an empty column header in a Decision Table resulted in a NullPointerException being thrown. The issue has been resolved by including an error message that warns the user not to leave the column header blank.
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Class to reproduce bug none

Description Jiri Svitak 2011-10-04 12:34:52 UTC
Created attachment 526236 [details]
Class to reproduce bug

Description of problem:
Empty column header in decision table throws NPE. Happens both with conditions and actions. Happens both with XLS and CSV. Error can be seen in attached example. The example contains error, but parser should not fail with NPE, but should respond with appropriate error message understandable by user.

Version-Release number of selected component (if applicable):
BRMS 5.2.0 ER5

How reproducible:
Run attached test case.

Steps to Reproduce:
1. Unzip test case.
2. Run as Java app.
  
Actual results:
XLS and CSV parsers throws NPE in described situation.

Expected results:
XLS and CSV should always respond with appropriate error message.

Comment 1 Jiri Svitak 2012-01-26 10:14:02 UTC
I have added a pull request with test case:
https://github.com/droolsjbpm/drools/pull/86

Comment 2 Geoffrey De Smet 2012-02-01 14:06:16 UTC
Fixed as requested: "respond with appropriate error message".

I've also looked extensively it is possible to support such an empty column header as that looks to be a valid use case, but the code design doesn't allow it easily.

Comment 4 Ryan Zhang 2012-02-15 09:13:11 UTC
Please verify the issue on 5.3 ER4.

Comment 5 Jiri Svitak 2012-02-21 11:08:00 UTC
Verified in 5.3 ER4.

Comment 6 lcarlon 2012-06-05 05:32:21 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Previously including an empty column header in a Decision Table resulted in a NullPointerException being thrown. The issue has been resolved by including an error message that warns the user not to leave the column header blank.