Bug 743410

Summary: Review Request: drupal7-login_destination - Customize login landing page in Drupal 7
Product: [Fedora] Fedora Reporter: Paul W. Frields <pfrields>
Component: Package ReviewAssignee: Peter Borsa <peter>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, peter, stickster
Target Milestone: ---Flags: peter: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: drupal7-login_destination-1.0-1.el5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-19 23:29:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 662103    

Description Paul W. Frields 2011-10-04 19:57:03 UTC
Spec URL: http://pfrields.fedorapeople.org/packages/SPECS/drupal7-login_destination.spec
SRPM URL: http://pfrields.fedorapeople.org/packages/SRPMS/drupal7-login_destination-1.0-1.fc16.src.rpm
The Login Destination module allows you to customize the destination
that a user is redirected to after logging in. The destination can be
an internal page or an external URL. It is possible to specify certain
conditions like referring pages or user roles and make the destination
depend upon them. You may use PHP snippets to provide custom
conditions and destinations. It also possible to keep users on the
currently visited page after logging in or out.

Comment 1 Peter Borsa 2011-10-11 16:15:38 UTC
MUST: rpmlint must be run on every package. The output should be posted
in the review.

$ rpmlint Downloads/drupal7-login_destination.spec Downloads/drupal7-login_destination-1.0-1.fc16.src.rpm 
drupal7-login_destination.src: W: spelling-error Summary(en_US) login -> loin, logic, lo gin
1 packages and 1 specfiles checked; 0 errors, 1 warnings.

MUST: The package must be named according to the Package Naming

MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.

MUST: The package must meet the Packaging Guidelines .

MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .

MUST: The License field in the package spec file must match the actual license.

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.

MUST: The spec file must be written in American English.

MUST: The spec file for the package MUST be legible.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

$ md5sum Downloads/login_destination-7.x-1.0.tar.gz ; curl -s -o - http://ftp.drupal.org/files/projects/login_destination-7.x-1.0.tar.gz | md5sum -
a86d6cbe60b787b60f44f217e64fb93f  Downloads/login_destination-7.x-1.0.tar.gz
a86d6cbe60b787b60f44f217e64fb93f  -

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.

N/A noarch package
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.

MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.

MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

N/A MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.

MUST: Packages must NOT bundle copies of system libraries.

MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.

MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory.

MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)

MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example.

MUST: Each package must consistently use macros.

MUST: The package must contain code, or permissable content.

MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).

MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.

N/A MUST: Header files must be in a -devel package.

N/A MUST: Static libraries must be in a -static package.

N/A MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.

N/A MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =

MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.

MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation. 

MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time.

MUST: All filenames in rpm packages must be valid UTF-8.



Comment 2 Paul W. Frields 2011-10-25 23:57:33 UTC
New Package SCM Request
Package Name: drupal7-login_destination
Short Description: Customize login landing page in Drupal 7
Owners: pfrields asrob
Branches: f15 f16 el5 el6
InitialCC: sdodson

Comment 3 Gwyn Ciesla 2011-10-26 00:49:28 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2011-11-08 15:19:23 UTC
drupal7-login_destination-1.0-1.el6 has been submitted as an update for Fedora EPEL 6.

Comment 5 Fedora Update System 2011-11-08 15:19:47 UTC
drupal7-login_destination-1.0-1.el5 has been submitted as an update for Fedora EPEL 5.

Comment 6 Fedora Update System 2011-11-08 15:20:08 UTC
drupal7-login_destination-1.0-1.fc16 has been submitted as an update for Fedora 16.

Comment 7 Fedora Update System 2011-11-08 15:20:35 UTC
drupal7-login_destination-1.0-1.fc15 has been submitted as an update for Fedora 15.

Comment 8 Fedora Update System 2011-11-10 07:30:51 UTC
drupal7-login_destination-1.0-1.el5 has been pushed to the Fedora EPEL 5 testing repository.

Comment 9 Fedora Update System 2011-11-19 23:29:10 UTC
drupal7-login_destination-1.0-1.fc16 has been pushed to the Fedora 16 stable repository.

Comment 10 Fedora Update System 2011-11-19 23:32:18 UTC
drupal7-login_destination-1.0-1.fc15 has been pushed to the Fedora 15 stable repository.

Comment 11 Fedora Update System 2011-11-28 19:26:50 UTC
drupal7-login_destination-1.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 12 Fedora Update System 2011-11-28 19:27:09 UTC
drupal7-login_destination-1.0-1.el5 has been pushed to the Fedora EPEL 5 stable repository.