Bug 743497

Taking this review. From a quick glance (full review forthcoming), everything looks good, but some items are no longer necessary:

- BuildRoot declaration (and clean-up in %install) only necessary if you want to target RHEL 5; you can surround them with %if %{el5} if you do target RHEL 5
- %clean section only needed in RHEL 5 & 6 (use %if %{rhel} if you want to target them)
- could you ask upstream for a standalone COPYING or LICENSE text, and put a comment linking to the request (if made on an issue tracker or mailing list) or indicating that the request has been made to the author?

* TODO Review [70%]
  - [X] Names [2/2]
    - [X] Package name
    - [X] Spec name
  - [X] Package version [2/2]
	http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning
    - [X] Version number
	  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag
    - [X] Release tag
	  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag
	  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
  - [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
  - [ ] Source files match upstream
        Please provide your own instructions, so the tarball generation is
        reproducible, rather than using the latest github snapshot.
        And perhaps use xz rather than gz?
        e.g.
        git clone git://github.com/bwalex/tc-play
        ( cd tc-play && \
          git archive --format=tar --prefix=%{name}-%{githash}/ %{githash} \
        ) | xz - > %{name}-%{githash}.tar.xz
  - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]]
  - [-] License [3/4]
    - [X] License is Fedora-approved
    - [X] No licensing conflict
    - [X] License field accurate
    - [ ] License included iff packaged by upstream
          please ask upstream for this
  - [X] rpmlint [2/2]
    - [X] on src.rpm
          tcplay.src: W: invalid-url Source0: bwalex-tc-play-59c6097.tar.gz
          1 packages and 0 specfiles checked; 0 errors, 1 warnings.
    - [X] on x86_64.rpm
          2 packages and 0 specfiles checked; 0 errors, 0 warnings.
  - [X] Language & locale [2/2]
    - [X] Spec in US English
    - [X] Spec legible
  - [X] Build [3/3]
    - [X] Koji results
          http://koji.fedoraproject.org/koji/taskinfo?taskID=3405450
    - [X] BRs complete
    - [X] Directory ownership
  - [-] Spec inspection [5/8]
    - [X] No duplicate files
    - [X] File permissions
    - [X] Filenames must be UTF-8
    - [ ] no BuildRoot ([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if targeting RHEL5]])
    - [ ] [RHEL]  %clean section
          https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean)
    - [ ] [RHEL 5] %buildroot cleaned on %install
          as noted in previous message, please indicate if you're targeting
          el5 and/or el6
    - [X] Macro usage consistent
    - [X] Documentation [1/1]
      - [X] %doc files are non-essential

(In reply to comment #1)
> Taking this review. From a quick glance (full review forthcoming), everything
> looks good, but some items are no longer necessary:
> 
> - BuildRoot declaration (and clean-up in %install) only necessary if you want
> to target RHEL 5; you can surround them with %if %{el5} if you do target RHEL 5
> - %clean section only needed in RHEL 5 & 6 (use %if %{rhel} if you want to
> target them)

My bad; I mean %if 0%{?el5} and %if 0%{?rhel}

Updated per your comments.  Thanks!

Spec URL: http://fedorapeople.org/~brouhaha/tcplay/tcplay.spec
SRPM URL:
http://fedorapeople.org/~brouhaha/tcplay/tcplay-0.9-0.2.20111004git59c6097.fc15.src.rpm
Koji scratch build for F15:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3411160

Updated to latest upstream, which added a LICENSE file.

Spec URL: http://fedorapeople.org/~brouhaha/tcplay/tcplay.spec
SRPM URL:
http://fedorapeople.org/~brouhaha/tcplay/tcplay-0.9-0.3.20111007git97ed5f9.fc14.src.rpm
Koji scratch build for F15: http://koji.fedoraproject.org/koji/taskinfo?taskID=3413307

I see that I overlooked a few of the requests and have been told that even RHEL6 doesn't need the buildroot cleaned in %install, so I've cleaned the spec up further.

Spec URL: http://fedorapeople.org/~brouhaha/tcplay/tcplay.spec
SRPM URL:
http://fedorapeople.org/~brouhaha/tcplay/tcplay-0.9-0.4.20111007git97ed5f9.fc14.src.rpm

Snapshot-creating script works; source hashes match, LICENSE file is now included and the macros are cleaned up.

Review APPROVED

New Package SCM Request
=======================
Package Name: tcplay
Short Description: Utility to create/open/map TrueCrypt-compatible volumes
Owners: brouhaha
Branches: f14 f15 f16 el6
InitialCC:

Git done (by process-git-requests).

tcplay-0.9-0.4.20111007git97ed5f9.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/tcplay-0.9-0.4.20111007git97ed5f9.fc16

tcplay-0.9-0.4.20111007git97ed5f9.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/tcplay-0.9-0.4.20111007git97ed5f9.fc15

tcplay-0.9-0.4.20111007git97ed5f9.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/tcplay-0.9-0.4.20111007git97ed5f9.fc14

tcplay-0.9-0.4.20111007git97ed5f9.fc16 has been pushed to the Fedora 16 testing repository.

tcplay-0.9-0.4.20111007git97ed5f9.fc15 has been pushed to the Fedora 15 stable repository.

tcplay-0.9-0.4.20111007git97ed5f9.fc14 has been pushed to the Fedora 14 stable repository.

tcplay-0.9-0.4.20111007git97ed5f9.fc16 has been pushed to the Fedora 16 stable repository.

tcplay-0.9-0.5.20111007git97ed5f9.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/tcplay-0.9-0.5.20111007git97ed5f9.el6

tcplay-0.9-0.5.20111007git97ed5f9.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.