Bug 743705

Summary: Fix GNOME 3.2
Product: [Fedora] Fedora Reporter: Jasper St. Pierre <jstpierr>
Component: gnome-shell-extension-pidginAssignee: Tom "spot" Callaway <tcallawa>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: igor.redhat, mclasen, tcallawa
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: gnome-shell-extension-pidgin-0-0.5.git80d4ea4b59.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-10-19 04:29:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jasper St. Pierre 2011-10-05 19:06:18 UTC
Fedora 16 ships a 'patch' for GNOME 3.2 which is completely incorrect[0].

Please ship BigE's[1] fork after he merges my changes[2], or KageSenshi should merge our changes.

[0] http://pkgs.fedoraproject.org/gitweb/?p=gnome-shell-extension-pidgin.git;a=blob;f=gnome-shell-extension-pidgin-gnome-shell-32.patch;h=2db3f99220336feaf4d76163835225bfa74987c0;hb=a9249ce69957f6420f063ad34b58083506fe3070

[1] https://github.com/BigE/gnome-shell-extensions-pidgin

[2] https://github.com/BigE/gnome-shell-extensions-pidgin/pull/2

Comment 1 Tom "spot" Callaway 2011-10-07 17:44:59 UTC
Thanks for the bug report. I'll work on applying the "completely correct" changes shortly. ;)

Comment 2 Jasper St. Pierre 2011-10-07 17:51:40 UTC
For reference, https://github.com/kagesenshi/gnome-shell-extensions-pidgin has merged BigE's changes, which have merged my changes, so just packaging the latest version of that should be fine.

Comment 3 Tom "spot" Callaway 2011-10-07 17:54:22 UTC
Great, thanks.

Comment 4 Tom "spot" Callaway 2011-10-07 18:01:44 UTC
FWIW, I have to apply this change, or the extension fails to start:

--- gnome-shell-extension-pidgin/extension.js.fix-metadata	2011-10-07 13:56:06.000000000 -0400
+++ gnome-shell-extension-pidgin/extension.js   2011-10-07 13:59:44.013711493 -0400
@@ -475,6 +475,6 @@ PidginClient.prototype = {
 }

 function init(metadata) {
-    imports.gettext.bindtextdomain('gnome-shell-extensions', metadata.localedir);
+    // imports.gettext.bindtextdomain('gnome-shell-extensions', metadata.localedir);
     return new PidginClient();
 }

Comment 5 Fedora Update System 2011-10-07 18:14:20 UTC
gnome-shell-extension-pidgin-0-0.5.git80d4ea4b59.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/gnome-shell-extension-pidgin-0-0.5.git80d4ea4b59.fc16

Comment 6 Fedora Update System 2011-10-08 23:33:00 UTC
Package gnome-shell-extension-pidgin-0-0.5.git80d4ea4b59.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gnome-shell-extension-pidgin-0-0.5.git80d4ea4b59.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2011-13943
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2011-10-19 04:29:45 UTC
gnome-shell-extension-pidgin-0-0.5.git80d4ea4b59.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.