Bug 743878

Summary:	Unclear Requires for rubygem-thor
Product:	[Fedora] Fedora	Reporter:	Bohuslav "Slavek" Kabrda <bkabrda>
Component:	rubygem-thor	Assignee:	Mo Morsi <mmorsi>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	lzap, mmorsi
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-02-14 17:08:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Bohuslav "Slavek" Kabrda 2011-10-06 11:17:28 UTC

Description of problem:

Hi,
I'm wondering, why the runtime dependency on rubygem(ParseTree) is necessary. I wasn't able to find any reference to it in the source code and thor seems to be working fine even when built and installed without ParseTree. Can you clarify this?

Version-Release number of selected component (if applicable): rubygem-thor-0.14.6-2

Thank you very much.

Comment 1 Mo Morsi 2011-10-07 10:39:55 UTC

Ah it looks like you are correct, there is no reference to ParseTree in the gem itself. That dependency was there when I took the package over (it may have been a requirement from before that was removed in the upstream project)

Since the spec suite is commented out in the check section (as its broken until Ruby 1.9 is in Fedora), could you please verify that thor works as intended before we remove this. Would like to just make sure that we don't inadvertently break anything.

Thank you greatly.

Comment 2 Bohuslav "Slavek" Kabrda 2011-10-07 12:00:36 UTC

For me, 6 tests fail for thor 0.14.6 and Ruby 1.9.3 and 1 test fails for thor 0.15.0.rc2:

rspec ./spec/actions/create_link_spec.rb:36 # Thor::Actions::CreateLink#invoke! creates a hard link for :symbolic => false

I will investigate whether the problems are on my or authors' side and create a bug report for them, if they show as bugs. I will let you know as soon as I have more info for you.

Most importantly, the other functionality seems to work fine, so I think it is safe to remove the ParseTree dependency.

Comment 3 Bohuslav "Slavek" Kabrda 2011-10-10 07:06:31 UTC

It seems that all tests failing in 0.14.6 are fixed in 0.15.0.rc2 (tested with both Ruby 1.8.7 and 1.9.3), but the one failing test (again, it fails both with Ruby 1.8.7 and 1.9.3) (the test is mentioned in the comment above).

I have created an issue on github for this bug:
https://github.com/wycats/thor/issues/183

When it's fixed, we can safely upgrade to 0.15.0, even for Ruby 1.8.7.

Comment 4 Bohuslav "Slavek" Kabrda 2011-10-13 06:16:42 UTC

Ok, so as the author said in https://github.com/wycats/thor/issues/183#issuecomment-2347720, the problem is in the tests, not in thor itself. I will submit a patch soon.

As a result, thor 0.15.0 works without ParseTree (be it with Ruby 1.8.7 or 1.9.3) and I would recommend upgrading to this version.

Comment 5 Lukas Zapletal 2012-01-24 12:32:16 UTC

Yes as you can see here:

http://lzap.fedorapeople.org/temp/katello/deps-jan2012.png

this rubygem requires gcc for the runtime. I guess it could live without it.

I can confirm Rails works without it if it helps. Did not test any unit tests or something like that.

Comment 6 Mo Morsi 2012-02-14 17:08:05 UTC

See that the dependency was removed with this commit.

http://pkgs.fedoraproject.org/gitweb/?p=rubygem-thor.git;a=commitdiff;h=58c6ee71672c8b66787b2117da3e30221de86e74

Closing.