| Summary: | Backend: java.lang.NullPointerException for RemoveVmTemplateFromImportExportCommand when trying to delete already deleted templates | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Dafna Ron <dron> | ||||||||
| Component: | ovirt-engine-core | Assignee: | Yair Zaslavsky <yzaslavs> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Omri Hochman <ohochman> | ||||||||
| Severity: | high | Docs Contact: | |||||||||
| Priority: | high | ||||||||||
| Version: | unspecified | CC: | amureini, hateya, iheim, lpeer, oourfali, Rhev-m-bugs, yeylon, ykaul, yzaslavs | ||||||||
| Target Milestone: | --- | Keywords: | Regression | ||||||||
| Target Release: | 3.3.4 | ||||||||||
| Hardware: | x86_64 | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | storage | ||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2012-12-17 07:49:24 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Attachments: |
|
||||||||||
Can you please try and reproduce this? tested in 3.1 and in 3.0 logs are attached for both
3.1 has some jboss exception but its not NPE:
2012-04-03 21:14:22,214 ERROR [org.ovirt.engine.core.bll.SPMAsyncTask] (pool-10-thread-50) BaseAsyncTask::RemoveTaskFromDB: Removing task dbef0646-b7b4-46cd-ac5a-3c6b7796be79 fr
om DataBase threw an exception.: org.apache.commons.lang.SerializationException: org.codehaus.jackson.map.JsonMappingException: Can not deserialize instance of org.ovirt.engine.
core.common.queries.DiskImageList out of START_ARRAY token
at [Source: java.io.StringReader@4d9d6cc; line: 24, column: 6] (through reference chain: org.ovirt.engine.core.common.action.VmTemplateImportExportParameters["images"])
at org.ovirt.engine.core.utils.serialization.json.JsonObjectDeserializer.readJsonString(JsonObjectDeserializer.java:69) [engine-utils.jar:]
at org.ovirt.engine.core.utils.serialization.json.JsonObjectDeserializer.deserialize(JsonObjectDeserializer.java:60) [engine-utils.jar:]
at org.ovirt.engine.core.dao.AsyncTaskDAODbFacadeImpl$AsyncTaskRowMapper.deserializeParameters(AsyncTaskDAODbFacadeImpl.java:56) [engine-dal.jar:]
at org.ovirt.engine.core.dao.AsyncTaskDAODbFacadeImpl$AsyncTaskRowMapper.mapRow(AsyncTaskDAODbFacadeImpl.java:44) [engine-dal.jar:]
at org.ovirt.engine.core.dao.AsyncTaskDAODbFacadeImpl$AsyncTaskRowMapper.mapRow(AsyncTaskDAODbFacadeImpl.java:31) [engine-dal.jar:]
at org.springframework.jdbc.core.RowMapperResultSetExtractor.extractData(RowMapperResultSetExtractor.java:92) [spring-jdbc-2.5.6.SEC03.jar:2.5.6.SEC03]
at org.springframework.jdbc.core.JdbcTemplate$1.doInPreparedStatement(JdbcTemplate.java:653) [spring-jdbc-2.5.6.SEC03.jar:2.5.6.SEC03]
at org.springframework.jdbc.core.JdbcTemplate.execute(JdbcTemplate.java:591) [spring-jdbc-2.5.6.SEC03.jar:2.5.6.SEC03]
at org.springframework.jdbc.core.JdbcTemplate.query(JdbcTemplate.java:641) [spring-jdbc-2.5.6.SEC03.jar:2.5.6.SEC03]
at org.springframework.jdbc.core.JdbcTemplate.query(JdbcTemplate.java:670) [spring-jdbc-2.5.6.SEC03.jar:2.5.6.SEC03]
3.0 still has the exception:
2012-04-03 22:00:27,793 ERROR [org.ovirt.engine.core.bll.RemoveVmTemplateFromImportExportCommand] (http-0.0.0.0-8443-1) Error during CanDoActionFailure.
java.lang.NullPointerException
at org.ovirt.engine.core.common.action.VmTemplateImportExportParameters.setImages(VmTemplateImportExportParameters.java:57)
at org.ovirt.engine.core.bll.RemoveVmTemplateFromImportExportCommand.canDoAction(RemoveVmTemplateFromImportExportCommand.java:69)
at org.ovirt.engine.core.bll.CommandBase.InternalCanDoAction(CommandBase.java:396)
at org.ovirt.engine.core.bll.CommandBase.CanDoActionOnly(CommandBase.java:192)
at org.ovirt.engine.core.bll.MultipleActionsRunner.Execute(MultipleActionsRunner.java:54)
at org.ovirt.engine.core.bll.Backend.runMultipleActionsImpl(Backend.java:353)
at org.ovirt.engine.core.bll.Backend.RunMultipleActions(Backend.java:330)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.jboss.aop.joinpoint.MethodInvocation.invokeTarget(MethodInvocation.java:122)
at org.jboss.aop.joinpoint.MethodInvocation.invokeNext(MethodInvocation.java:111)
at org.jboss.ejb3.interceptors.container.ContainerMethodInvocationWrapper.invokeNext(ContainerMethodInvocationWrapper.java:72)
at org.jboss.ejb3.interceptors.aop.InvocationContextInterceptor$InvocationContext.proceed(InvocationContextInterceptor.java:138)
at org.ovirt.engine.core.utils.ThreadLocalSessionCleanerInterceptor.injectWebContextToThreadLocal(ThreadLocalSessionCleanerInterceptor.java:11)
at sun.reflect.GeneratedMethodAccessor281.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
Created attachment 574933 [details]
log
Please reproduce on latest SI build Adding to previous comment - And of course, attach logs (some of the code there was changed, and I cannot reproduce). Unable to reproduce the NPE in build - si3, following the scenario above provide an empty CanDoAction GUI Message. that should be fix.
User GUI Message :
*****************
Error:
tmp3:
No Message
tmp2:
No Message
tmp1:
No Message
engine.log:
************
2012-05-08 10:06:33,178 INFO [org.ovirt.engine.core.bll.MultipleActionsRunner] (pool-10-thread-48) Start time: 5/8/12 10:06 AM. Start running CanDoAction for command number 2/3 (Command type: RemoveVmTemplateFrom
ImportExport)
2012-05-08 10:06:33,178 INFO [org.ovirt.engine.core.bll.MultipleActionsRunner] (pool-10-thread-47) Start time: 5/8/12 10:06 AM. Start running CanDoAction for command number 1/3 (Command type: RemoveVmTemplateFrom
ImportExport)
2012-05-08 10:06:33,180 INFO [org.ovirt.engine.core.bll.MultipleActionsRunner] (pool-10-thread-46) Start time: 5/8/12 10:06 AM. Start running CanDoAction for command number 3/3 (Command type: RemoveVmTemplateFrom
ImportExport)
2012-05-08 10:06:33,183 INFO [org.ovirt.engine.core.vdsbroker.irsbroker.GetVmsInfoVDSCommand] (ajp--0.0.0.0-8009-4) START, GetVmsInfoVDSCommand(storagePoolId = adac56a5-0e0b-4c48-b83a-50c9d1488e85, ignoreFailover
Limit = false, compatabilityVersion = null, storageDomainId = 49c11796-14dd-4440-8470-5af4abe6844e, vmIdList = null), log id: 495935dc
2012-05-08 10:06:33,190 INFO [org.ovirt.engine.core.vdsbroker.irsbroker.GetVmsInfoVDSCommand] (pool-10-thread-46) START, GetVmsInfoVDSCommand(storagePoolId = adac56a5-0e0b-4c48-b83a-50c9d1488e85, ignoreFailoverLi
mit = false, compatabilityVersion = null, storageDomainId = 49c11796-14dd-4440-8470-5af4abe6844e, vmIdList = null), log id: 37e7a2d0
2012-05-08 10:06:33,194 INFO [org.ovirt.engine.core.vdsbroker.irsbroker.GetVmsInfoVDSCommand] (pool-10-thread-48) START, GetVmsInfoVDSCommand(storagePoolId = adac56a5-0e0b-4c48-b83a-50c9d1488e85, ignoreFailoverLi
mit = false, compatabilityVersion = null, storageDomainId = 49c11796-14dd-4440-8470-5af4abe6844e, vmIdList = null), log id: 3365b808
2012-05-08 10:06:33,194 INFO [org.ovirt.engine.core.vdsbroker.irsbroker.GetVmsInfoVDSCommand] (pool-10-thread-47) START, GetVmsInfoVDSCommand(storagePoolId = adac56a5-0e0b-4c48-b83a-50c9d1488e85, ignoreFailoverLi
mit = false, compatabilityVersion = null, storageDomainId = 49c11796-14dd-4440-8470-5af4abe6844e, vmIdList = null), log id: 388b5b6c
2012-05-08 10:06:33,199 INFO [org.ovirt.engine.core.vdsbroker.irsbroker.GetVmsInfoVDSCommand] (ajp--0.0.0.0-8009-4) FINISH, GetVmsInfoVDSCommand, log id: 495935dc
2012-05-08 10:06:33,212 INFO [org.ovirt.engine.core.vdsbroker.irsbroker.GetVmsInfoVDSCommand] (pool-10-thread-47) FINISH, GetVmsInfoVDSCommand, log id: 388b5b6c
2012-05-08 10:06:33,224 WARN [org.ovirt.engine.core.bll.RemoveVmTemplateFromImportExportCommand] (pool-10-thread-47) CanDoAction of action RemoveVmTemplateFromImportExport failed. Reasons:VAR__ACTION__REMOVE,VAR_
_TYPE__VM_TEMPLATE
2012-05-08 10:06:33,227 INFO [org.ovirt.engine.core.vdsbroker.irsbroker.GetVmsInfoVDSCommand] (pool-10-thread-48) FINISH, GetVmsInfoVDSCommand, log id: 3365b808
2012-05-08 10:06:33,229 INFO [org.ovirt.engine.core.bll.MultipleActionsRunner] (pool-10-thread-47) End time: 5/8/12 10:06 AM. Finish handling CanDoAction for command number 1/3 (Command type: RemoveVmTemplateFrom
ImportExport)
2012-05-08 10:06:33,239 INFO [org.ovirt.engine.core.vdsbroker.irsbroker.GetVmsInfoVDSCommand] (pool-10-thread-46) FINISH, GetVmsInfoVDSCommand, log id: 37e7a2d0
2012-05-08 10:06:33,241 WARN [org.ovirt.engine.core.bll.RemoveVmTemplateFromImportExportCommand] (pool-10-thread-48) CanDoAction of action RemoveVmTemplateFromImportExport failed. Reasons:VAR__ACTION__REMOVE,VAR_
_TYPE__VM_TEMPLATE
2012-05-08 10:06:33,249 INFO [org.ovirt.engine.core.bll.MultipleActionsRunner] (pool-10-thread-48) End time: 5/8/12 10:06 AM. Finish handling CanDoAction for command number 2/3 (Command type: RemoveVmTemplateFrom
ImportExport)
2012-05-08 10:06:33,254 WARN [org.ovirt.engine.core.bll.RemoveVmTemplateFromImportExportCommand] (pool-10-thread-46) CanDoAction of action RemoveVmTemplateFromImportExport failed. Reasons:VAR__ACTION__REMOVE,VAR_
_TYPE__VM_TEMPLATE
2012-05-08 10:06:33,257 INFO [org.ovirt.engine.core.bll.MultipleActionsRunner] (pool-10-thread-46) End time: 5/8/12 10:06 AM. Finish handling CanDoAction for command number 3/3 (Command type: RemoveVmTemplateFrom
ImportExport)
Created attachment 582894 [details] comment7_engine.log Unable to reproduce the original Issue with the NPE - opened a new Bz #819764 for the problem described in Comment #7. Thanks I will close this bug. (In reply to comment #9) > Unable to reproduce the original Issue with the NPE - opened a new Bz #819764 > for the problem described in Comment #7. Verified si3. |
Created attachment 526760 [details] rhevm log Description of problem: after removing templates from NFS Export domain without refreshing the Template sub tab you can still select the templates and try to remove them again. When you do that you get a NPE and an empty CanDoAction. Version-Release number of selected component (if applicable): ic144 How reproducible: 100% Steps to Reproduce: 1. export several templates to NFS Export Domain 2. remove multiple templates 3. select the templates again without refreshing the sub tab and try to remove them again Actual results: you get NPE and empty CanDoAction in Admin GUI Expected results: You should get a CanDoAction warning Additional info: full rhevm log attached 2011-10-06 19:46:08,579 ERROR [org.ovirt.engine.core.bll.RemoveVmTemplateFromImportExportCommand] (pool-11-thread-343) Error during CanDoActionFailure. java.lang.NullPointerException at org.ovirt.engine.core.common.action.VmTemplateImportExportParameters.setImages(VmTemplateImportExportParameters.java:57) at org.ovirt.engine.core.bll.RemoveVmTemplateFromImportExportCommand.canDoAction(RemoveVmTemplateFromImportExportCommand.java:69) at org.ovirt.engine.core.bll.CommandBase.InternalCanDoAction(CommandBase.java:396) at org.ovirt.engine.core.bll.CommandBase.CanDoActionOnly(CommandBase.java:192) at org.ovirt.engine.core.bll.MultipleActionsRunner$2.run(MultipleActionsRunner.java:109) at org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil$InternalWrapperRunnable.run(ThreadPoolUtil.java:46) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) 2011-10-06 19:46:08,581 INFO [org.ovirt.engine.core.bll.MultipleActionsRunner] (pool-11-thread-343) End time: 10/6/11 7:46 PM. Finish handling CanDoAction for command number 4/ 5 (Command type: RemoveVmTemplateFromImportExport) 2011-10-06 19:46:08,826 ERROR [org.ovirt.engine.core.bll.RemoveVmTemplateFromImportExportCommand] (pool-11-thread-348) Error during CanDoActionFailure. java.lang.NullPointerException at org.ovirt.engine.core.common.action.VmTemplateImportExportParameters.setImages(VmTemplateImportExportParameters.java:57) at org.ovirt.engine.core.bll.RemoveVmTemplateFromImportExportCommand.canDoAction(RemoveVmTemplateFromImportExportCommand.java:69) at org.ovirt.engine.core.bll.CommandBase.InternalCanDoAction(CommandBase.java:396) at org.ovirt.engine.core.bll.CommandBase.CanDoActionOnly(CommandBase.java:192) at org.ovirt.engine.core.bll.MultipleActionsRunner$2.run(MultipleActionsRunner.java:109) at org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil$InternalWrapperRunnable.run(ThreadPoolUtil.java:46) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662) 2011-10-06 19:46:08,842 INFO [org.ovirt.engine.core.bll.MultipleActionsRunner] (pool-11-thread-348) End time: 10/6/11 7:46 PM. Finish handling CanDoAction for command number 2/5 (Command type: RemoveVmTemplateFromImportExport) 2011-10-06 19:46:08,862 ERROR [org.ovirt.engine.core.bll.RemoveVmTemplateFromImportExportCommand] (pool-11-thread-347) Error during CanDoActionFailure. java.lang.NullPointerException