Bug 744342

Summary:	Review Request: python-configshell - Library for configuration shell development
Product:	[Fedora] Fedora	Reporter:	Andy Grover <agrover>
Component:	Package Review	Assignee:	Tomasz Torcz <tomek>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, tomek
Target Milestone:	---	Flags:	tomek: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-11-17 01:45:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	744340

Description Andy Grover 2011-10-07 22:24:51 UTC

Spec URL: http://fedorapeople.org/gitweb?p=grover/public_git/python-configshell.git;a=blob;f=python-configshell.spec;h=0b2c14e4fa5c2bb0787991c9d7c363cf521e019a;hb=208e7ba217211b89fd5faf3a30fdb682a8206ba3

SRPM URL: http://grover.fedorapeople.org/srpms/python-configshell-1.99.1.git987b63b-5.el6.src.rpm

Description: This is a dependency for targetcli, see bug 744340. This was reviewed for RHEL by dmalcolm. There still aren't tarballs of tagged releases yet, so this relies on a git snapshot.

Comment 1 Tomasz Torcz 2011-11-08 20:14:14 UTC

%define could be replace by %global

Review:
- rpmlint is silent
- *pyc, *pyo and egginfo files are properly included
- md5sum of checkout matches provided sources
- name is fine
- license matches
- it builds
- do not bundle any system libraries
- permissions are sane
- macro use is OK

Hi, I'm ttorcz and I approve this package ;-)

Comment 2 Andy Grover 2011-11-08 21:20:59 UTC

New Package SCM Request
=======================
Package Name: python-configshell
Short Description: A framework to implement simple but nice CLIs
Owners: grover
Branches: f16
InitialCC: ttorcz

Comment 3 Gwyn Ciesla 2011-11-08 21:21:31 UTC

Git done (by process-git-requests).