Bug 744347

Summary:	Review Request: python-simpleparse - a parser generator
Product:	[Fedora] Fedora	Reporter:	Andy Grover <agrover>
Component:	Package Review	Assignee:	Tomasz Torcz <tomek>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, pingou, tomek
Target Milestone:	---	Flags:	tomek: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-11-17 01:45:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	744340

Description Andy Grover 2011-10-07 22:31:41 UTC

Spec URL: http://fedorapeople.org/gitweb?p=grover/public_git/python-simpleparse.git;a=blob;f=python-simpleparse.spec;h=2b2a31af3b92781674e54e94633b6881a1cd7658;hb=e8cda65aee096ccafa79535e6eee14a411b71f36

SRPM URL: http://grover.fedorapeople.org/srpms/python-simpleparse-2.1.1-3.el6.src.rpm

Description: This software has been around for a long time, but the motivation for packaging it now is to enable targetcli, see bug 744340. It was reviewed for RHEL packaging by dmalcolm. The only weird thing about this is that it includes a private version of mxttexttools (upstream does this too) so the spec needs to make sure the .so is not exported as a provides.

Comment 1 Pierre-YvesChibon 2011-10-11 16:40:17 UTC

I believe you should use %global instead of %define.

Also, why :
%exclude %{python_sitearch}/simpleparse/tests
%exclude %{python_sitearch}/simpleparse/examples
?

Comment 2 Andy Grover 2011-10-12 23:52:53 UTC

(In reply to comment #1)
> I believe you should use %global instead of %define.

OK will fix.

> Also, why :
> %exclude %{python_sitearch}/simpleparse/tests
> %exclude %{python_sitearch}/simpleparse/examples
> ?

examples seemed better included in %doc. I also thought tests were not relevant to the installed package, but we can put them in %doc or leave them in python_sitearch if that's preferable, please advise.

Comment 3 Tomasz Torcz 2011-11-08 19:55:41 UTC

I find examples in %doc to be better - easy to find, and after all, those are examples, not to be dependent on.

Rest of review:
- *pyo and *pyc properly included
- rpmlint silent (apart from wrong spelling suggestion)
- package name is OK
- license OK
- source md5sum matches upstream
- build fine on my machine
- permissions are sane
- macro use is consistent

So, I approve this package. Thanks for packaging.

BTW, my FAS account is "ttorcz".

Comment 4 Andy Grover 2011-11-08 21:18:36 UTC

New Package SCM Request
=======================
Package Name: python-simpleparse
Short Description: A simple and fast parser generator
Owners: grover
Branches: f16
InitialCC: ttorcz

Comment 5 Gwyn Ciesla 2011-11-08 21:22:08 UTC

Git done (by process-git-requests).