Bug 744548

Summary:	Attaching to a nonexistent PID causes libvirtd to crash
Product:	Red Hat Enterprise Linux 6	Reporter:	Michal Privoznik <mprivozn>
Component:	libvirt	Assignee:	Michal Privoznik <mprivozn>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.2	CC:	acathrow, ajia, gren, mzhan, rwu, veillard, weizhan, whuang
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-0.9.4-17.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-06 11:37:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	747120

Description Michal Privoznik 2011-10-09 10:34:53 UTC

Description of problem:
If an attaching to qemu process fails, e.g. invalid PID was supplied, libvirtd crashes. The problem lies within qemu driver which frees uninitialized variable.


Version-Release number of selected component (if applicable):
libvirt-0.9.4-16.el6

How reproducible:
100%

Steps to Reproduce:
1. get random number and make sure no such PID exists
2. virsh qemu-attach $PID
3. observe libvirtd SIGSEGV
  
Actual results:
the daemon crashes

Expected results:
an error printed (something like non-existing PID) and no deamon crash

Additional info:

Comment 1 Michal Privoznik 2011-10-09 10:43:18 UTC

Moving to POST:

http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-October/msg00251.html

Comment 4 Huang Wenlong 2011-10-12 03:20:14 UTC

Verify this bug with libvirt-0.9.4-17.el6.x86_64

[root@5-12-r6 ~]# virsh qemu-attach 33333344
11:18:54.185: 18201: error : virFileReadAll:451 : Failed to open file '/proc/33333344/cmdline': No such file or directory
error: Failed to open file '/proc/33333344/cmdline': No such file or directory

[root@5-12-r6 ~]# /etc/init.d/libvirtd status
libvirtd (pid  18197) is running...

Comment 5 errata-xmlrpc 2011-12-06 11:37:14 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1513.html