Bug 744596

Summary:	[abrt] soundconverter-1.5.4-9.fc15: soundconverter:2038:generate_filename:TypeError: cannot concatenate 'str' and 'NoneType' objects
Product:	[Fedora] Fedora	Reporter:	Fabrício Godoy <skarllot>
Component:	soundconverter	Assignee:	Michael Schwendt <bugs.michael>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	15	CC:	bugs.michael, lxtnow
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Unspecified
Whiteboard:	abrt_hash:54a18b6e7a4a401a04a846c0656d1079cec706d5
Fixed In Version:	soundconverter-1.5.4-10.fc15	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-10-18 22:11:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fabrício Godoy 2011-10-09 16:54:35 UTC

abrt version: 2.0.3
architecture:   x86_64
cmdline:        
comment:        Won't start
component:      soundconverter
executable:     /usr/bin/soundconverter
kernel:         2.6.40.4-5.fc15.x86_64
os_release:     Fedora release 15 (Lovelock)
package:        soundconverter-1.5.4-9.fc15
reason:         soundconverter:2038:generate_filename:TypeError: cannot concatenate 'str' and 'NoneType' objects
time:           Sun Oct  9 13:25:23 2011
uid:            500
username:       fabricio

backtrace:
:soundconverter:2038:generate_filename:TypeError: cannot concatenate 'str' and 'NoneType' objects
:
:Traceback (most recent call last):
:  File "/usr/bin/soundconverter", line 2131, in on_subfolder_pattern_changed
:    self.update_example()
:  File "/usr/bin/soundconverter", line 1992, in update_example
:    s = markup_escape(beautify_uri(self.generate_filename(sound_file, for_display=True)))
:  File "/usr/bin/soundconverter", line 2038, in generate_filename
:    'gst-profile': '.' + profile_ext,
:TypeError: cannot concatenate 'str' and 'NoneType' objects
:
:Local variables in innermost frame:
:profile: None
:for_display: True
:profile_ext: None
:sound_file: <__main__.SoundFile instance at 0x2f790e0>
:self: <__main__.PreferencesDialog object at 0x2f75b10>
:output_type: 'audio/mpeg'

Comment 1 Fabrício Godoy 2011-10-09 17:00:06 UTC

On nautilus-sound-converter I've found just profiles with '<no name>' name, all to wav format. I've delete these.
Now soundconverter start normally.

Comment 2 Michael Schwendt 2011-10-09 18:20:42 UTC

It's a pitty you've deleted the profiles without that I could have taken a look at them. I've had to guess based on the variables' values. With the current code, multiple profiles with no description and no extension is a bad idea.

Comment 3 Fedora Update System 2011-10-09 18:47:35 UTC

soundconverter-1.5.4-10.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/soundconverter-1.5.4-10.fc15

Comment 4 Fedora Update System 2011-10-10 02:50:28 UTC

Package soundconverter-1.5.4-10.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing soundconverter-1.5.4-10.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2011-14090
then log in and leave karma (feedback).

Comment 5 Fabrício Godoy 2011-10-13 03:51:51 UTC

I have some snapshots from "/home".
Where can I find these profiles?

Comment 6 Michael Schwendt 2011-10-13 09:24:26 UTC

They are stored in GConf. Example:

$ gconftool-2 --get /system/gstreamer/0.10/audio/global/profile_list
[voicelossy,voicelossless,mp3,mp2,cdlossy,cdlossless,aac]

Display "voicelossy" profile:

$ gconftool-2 -a /system/gstreamer/0.10/audio/profiles/voicelossy
 active = true
 description = Used for converting to lossy voice-quality audio. Use this for recording speech that doesn't need to be edited.
 pipeline = audio/x-raw-int,rate=32000,channels=1 ! speexenc name=enc ! oggmux
 extension = spx
 name = Voice, Lossy

[...]

SoundConverter's implementation stores these profiles _by description_, which e.g. means multiple profiles with no description would clash. (There are other limitations, related to supporting the audio profiles, that have been worked around before.)

Comment 7 Michael Schwendt 2011-10-13 09:28:21 UTC

> _by description_

Meant to write _by name_, but got it wrong because the source code stores the name in a variable "description", so it's easy to get that wrong. ;-)

Comment 8 Fabrício Godoy 2011-10-13 16:16:05 UTC

(In reply to comment #6)
> They are stored in GConf. Example:
> 
> $ gconftool-2 --get /system/gstreamer/0.10/audio/global/profile_list
> [voicelossy,voicelossless,mp3,mp2,cdlossy,cdlossless,aac]
> 
> Display "voicelossy" profile:
> 
> $ gconftool-2 -a /system/gstreamer/0.10/audio/profiles/voicelossy
>  active = true
>  description = Used for converting to lossy voice-quality audio. Use this for
> recording speech that doesn't need to be edited.
>  pipeline = audio/x-raw-int,rate=32000,channels=1 ! speexenc name=enc ! oggmux
>  extension = spx
>  name = Voice, Lossy
> 
> [...]
> 
> SoundConverter's implementation stores these profiles _by description_, which
> e.g. means multiple profiles with no description would clash. (There are other
> limitations, related to supporting the audio profiles, that have been worked
> around before.)

Which file?
I need to know file path to inspect into my snapshots.

Comment 9 Michael Schwendt 2011-10-13 17:19:47 UTC

The corresponding XML files are found below $HOME/.gconf/
So, for custom ones, the tree $HOME/.gconf/system/gstreamer/0.10/audio/

Comment 10 Fabrício Godoy 2011-10-17 00:52:30 UTC

Sorry, ".*" aren't into my snapshots.

Comment 11 Fedora Update System 2011-10-18 22:11:54 UTC

soundconverter-1.5.4-10.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.