Bug 744671

Summary: Option to enable 'Enter' to save and move to the next string and use Shift+Enter to add a new line
Product: [Retired] Zanata Reporter: James Ni <jni>
Component: Component-UIAssignee: Runa Bhattacharjee <runab>
Status: CLOSED CURRENTRELEASE QA Contact: Ding-Yi Chen <dchen>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.4CC: aeng, ankit, sflaniga, zanata-bugs
Target Milestone: ---   
Target Release: 1.4.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-10-28 07:02:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 740191, 743789    

Description James Ni 2011-10-10 05:55:10 UTC
As a translator I want a to set an Option to enable 'Enter' to save and move to the next string and use Shift+Enter to add a new line, so that I can quickly edit and navigate while working on on the editor

-add options menu to enable 'Enter' to save and move to the next string
-dynamically change tooltips for Save as Approved button

Comment 2 Ding-Yi Chen 2011-10-12 02:11:45 UTC
James, this bug is re-assigned to you because:

1. Ctrl-Enter should still be working as "Saved as Approved" when "Enable 'Enter' Key to save" is off.

2. Shift-Enter should be able to insert the newline, no matter "Enable 'Enter' Key to save" is on or off.

Comment 3 James Ni 2011-10-12 06:01:51 UTC
(In reply to comment #2)
> James, this bug is re-assigned to you because:
> 
> 1. Ctrl-Enter should still be working as "Saved as Approved" when "Enable
> 'Enter' Key to save" is off.
> 
> 2. Shift-Enter should be able to insert the newline, no matter "Enable 'Enter'
> Key to save" is on or off.

OK, I will reinstate the Ctrl-Enter, and make 'Shift-Enter' be able to insert the newline, when "Enable 'Enter' Key to save" is on

Comment 4 James Ni 2011-10-12 08:04:42 UTC
Hi Ding,

I have modified the code to reinstate Ctrl-Enter to be working as "Saved as Approved" when "Enable 'Enter' Key to save" is off.

I also found that Shift-Enter should be able to insert the newline when "Enable 'Enter' Key to save" is off. And we don't need any further key event handler for Shift-Enter when "Enable 'Enter' Key to save" is off.

Comment 5 Sean Flanigan 2011-10-14 06:28:32 UTC
Dean, are you happy with this now?

Comment 6 Ding-Yi Chen 2011-10-17 00:58:38 UTC
VERIFIED with Zanata version 1.4.2-SNAPSHOT (20111014-1658).