Bug 744671
Summary: | Option to enable 'Enter' to save and move to the next string and use Shift+Enter to add a new line | ||
---|---|---|---|
Product: | [Retired] Zanata | Reporter: | James Ni <jni> |
Component: | Component-UI | Assignee: | Runa Bhattacharjee <runab> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Ding-Yi Chen <dchen> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 1.4 | CC: | aeng, ankit, sflaniga, zanata-bugs |
Target Milestone: | --- | ||
Target Release: | 1.4.2 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-10-28 07:02:42 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 740191, 743789 |
Description
James Ni
2011-10-10 05:55:10 UTC
Implemented. see https://github.com/zanata/zanata/commit/a056bda2b6da8cc59818c49e6a99896aa5e84c3d and https://github.com/zanata/zanata/commit/33b38473fdd7af19fca8f7f919ebd409ec761b5c James, this bug is re-assigned to you because: 1. Ctrl-Enter should still be working as "Saved as Approved" when "Enable 'Enter' Key to save" is off. 2. Shift-Enter should be able to insert the newline, no matter "Enable 'Enter' Key to save" is on or off. (In reply to comment #2) > James, this bug is re-assigned to you because: > > 1. Ctrl-Enter should still be working as "Saved as Approved" when "Enable > 'Enter' Key to save" is off. > > 2. Shift-Enter should be able to insert the newline, no matter "Enable 'Enter' > Key to save" is on or off. OK, I will reinstate the Ctrl-Enter, and make 'Shift-Enter' be able to insert the newline, when "Enable 'Enter' Key to save" is on Hi Ding, I have modified the code to reinstate Ctrl-Enter to be working as "Saved as Approved" when "Enable 'Enter' Key to save" is off. I also found that Shift-Enter should be able to insert the newline when "Enable 'Enter' Key to save" is off. And we don't need any further key event handler for Shift-Enter when "Enable 'Enter' Key to save" is off. Dean, are you happy with this now? VERIFIED with Zanata version 1.4.2-SNAPSHOT (20111014-1658). |