Bug 744678

Summary: [vdsm] createImageRollback doesn't remove directory
Product: [Retired] oVirt Reporter: Jakub Libosvar <jlibosva>
Component: vdsmAssignee: Dan Kenigsberg <danken>
Status: CLOSED WONTFIX QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: abaron, acathrow, amureini, bazulay, dyasny, iheim, mgoldboi, ykaul
Target Milestone: ---   
Target Release: 3.3.4   
Hardware: x86_64   
OS: Linux   
Whiteboard: storage
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-03-11 21:58:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
vdsm log none

Description Jakub Libosvar 2011-10-10 07:16:20 UTC 
Description of problem:
When new disk creation fails, image file is removed properly but due to directory which contained this file is now empty, vdsm doesn't remove the directory. Relevant to NFS/local storage only.

Version-Release number of selected component (if applicable):
vdsm-4.9-106.el6.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Start creating new VM's disk
2. Restart vdsmd in the middle of task
3. Check image/ directory on data domain
  
Actual results:
Directory was not removed

Expected results:
Directory is removed

Additional info:
2a17453e-c5d1-4822-af5a-bbfcfedd25d9::DEBUG::2011-10-10 09:04:30,674::task::495::TaskManager.Task::(_debug) Task 2a17453e-c5d1-4822-af5a-bbfcfedd25d9: running recovery create image rollback: e8ee2df7-2221-48a7-b16b-a6652c351ec4: Image->createImageRollback(/rhev/data-center/3c250720-5b6d-4053-89c5-38a7db5ec68c/18d2d242-9758-4806-a6e0-8f1e3c1cbd77/images/e8ee2df7-2221-48a7-b16b-a6652c351ec4)
2a17453e-c5d1-4822-af5a-bbfcfedd25d9::INFO::2011-10-10 09:04:30,675::image::65::Storage.Image::(createImageRollback) createImageRollback: imageDir=/rhev/data-center/3c250720-5b6d-4053-89c5-38a7db5ec68c/18d2d242-9758-4806-a6e0-8f1e3c1cbd77/images/e8ee2df7-2221-48a7-b16b-a6652c351ec4
2a17453e-c5d1-4822-af5a-bbfcfedd25d9::ERROR::2011-10-10 09:04:30,676::image::70::Storage.Image::(createImageRollback) createImageRollback: Cannot remove dirty image folder /rhev/data-center/3c250720-5b6d-4053-89c5-38a7db5ec68c/18d2d242-9758-4806-a6e0-8f1e3c1cbd77/images/e8ee2df7-2221-48a7-b16b-a6652c351ec4
Comment 1 Jakub Libosvar 2011-10-10 07:16:47 UTC 
Created attachment 527172 [details]
vdsm log
Comment 2 Jakub Libosvar 2011-10-10 07:50:08 UTC 
(In reply to comment #0)
> Description of problem:
> but due to directory which contained this file is now empty, vdsm doesn't remove the directory.

Correction - seems like the directory is still containing the file when attempting to delete
Comment 3 Jakub Libosvar 2011-10-10 07:54:06 UTC 
The file is called .nfs0000000000fe001800000005. Is it just some temporary file? I cannot see it later.
Comment 4 Dan Kenigsberg 2012-04-10 18:53:38 UTC 
yeah, that file is created by the nfs server, and is removed after a successful umount.

We may want to initiate a cleanup of such empty directories on the spm.
Comment 5 Itamar Heim 2013-03-11 21:58:20 UTC 
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.