Bug 744725
Summary: | Review Request: opus - An audio codec for use in low-delay speech and audio communication | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Robinson <pbrobinson> |
Component: | Package Review | Assignee: | Mario Blättermann <mario.blaettermann> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | lemenkov, mario.blaettermann, notting, package-review, tcallawa |
Target Milestone: | --- | Flags: | mario.blaettermann:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-10-24 18:50:34 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Peter Robinson
2011-10-10 10:24:01 UTC
$ rpmlint -i -v * opus.i686: I: checking opus.i686: W: spelling-error Summary(en_US) codec -> codex, code, codes The value of this tag appears to be misspelled. Please double-check. opus.i686: W: spelling-error %description -l en_US codec -> codex, code, codes The value of this tag appears to be misspelled. Please double-check. opus.i686: W: spelling-error %description -l en_US Org's -> Erg's, Ora's, Orr's The value of this tag appears to be misspelled. Please double-check. opus.i686: I: checking-url http://www.opus-codec.org/ (timeout 10 seconds) opus.src: I: checking opus.src: W: spelling-error Summary(en_US) codec -> codex, code, codes The value of this tag appears to be misspelled. Please double-check. opus.src: W: spelling-error %description -l en_US codec -> codex, code, codes The value of this tag appears to be misspelled. Please double-check. opus.src: W: spelling-error %description -l en_US Org's -> Erg's, Ora's, Orr's The value of this tag appears to be misspelled. Please double-check. opus.src: I: checking-url http://www.opus-codec.org/ (timeout 10 seconds) opus.src: I: checking-url http://tools.ietf.org/id/draft-ietf-codec-opus-08.txt (timeout 10 seconds) opus.src: I: checking-url http://downloads.xiph.org/releases/opus/opus-0.9.6.tar.gz (timeout 10 seconds) opus.x86_64: I: checking opus.x86_64: W: spelling-error Summary(en_US) codec -> codex, code, codes The value of this tag appears to be misspelled. Please double-check. opus.x86_64: W: spelling-error %description -l en_US codec -> codex, code, codes The value of this tag appears to be misspelled. Please double-check. opus.x86_64: W: spelling-error %description -l en_US Org's -> Erg's, Ora's, Orr's The value of this tag appears to be misspelled. Please double-check. opus.x86_64: I: checking-url http://www.opus-codec.org/ (timeout 10 seconds) opus-debuginfo.i686: I: checking opus-debuginfo.i686: I: checking-url http://www.opus-codec.org/ (timeout 10 seconds) opus-debuginfo.x86_64: I: checking opus-debuginfo.x86_64: I: checking-url http://www.opus-codec.org/ (timeout 10 seconds) opus-devel.i686: I: checking opus-devel.i686: I: checking-url http://www.opus-codec.org/ (timeout 10 seconds) opus-devel.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. opus-devel.x86_64: I: checking opus-devel.x86_64: I: checking-url http://www.opus-codec.org/ (timeout 10 seconds) opus-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. opus.spec: I: checking-url http://tools.ietf.org/id/draft-ietf-codec-opus-08.txt (timeout 10 seconds) opus.spec: I: checking-url http://downloads.xiph.org/releases/opus/opus-0.9.6.tar.gz (timeout 10 seconds) 7 packages and 1 specfiles checked; 0 errors, 11 warnings. Some ignorable spelling errors, and "missing docs" from the -devel package. It's odd that this is a warning. The base package ships the appropriate docs anyway. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. BSD [+] MUST: The License field in the package spec file must match the actual license. [.] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 030556bcaebb241505f8577e92abe6d4 opus-0.9.6.tar.gz 030556bcaebb241505f8577e92abe6d4 opus-0.9.6.tar.gz.packaged [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [+] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. Tested on F15. Works as expected. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts. Currently no manpage available. ---------------- PACKAGE APPROVED ---------------- New Package GIT Request ======================= Package Name: opus Short Description: An audio codec for use in low-delay speech and audio communication Owners: pbrobinson Branches: F-15 F-16 InitialCC: Git done (by process-git-requests). *** Bug 856636 has been marked as a duplicate of this bug. *** New Package GIT Request ======================= Package Name: opus Short Description: An audio codec for use in low-delay speech and audio communication Owners: pbrobinson Branches: F-15 F-16 EL-5 EL-6 InitialCC: Already exists, submit a Change request for EL branches. Package Change Request ====================== Package Name: opus New Branches: EL-6 EL-5 Owners: pbrobinson Git done (by process-git-requests). |