Bug 745293

Summary: Review Request: drupal7-cck cck allows you to add custom fields to nodes using a web browser
Product: [Fedora] Fedora Reporter: Scott Dodson <sdodson>
Component: Package ReviewAssignee: Gwyn Ciesla <gwync>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: gwync, notting, package-review
Target Milestone: ---Flags: gwync: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: drupal7-cck-2-0.1.dev.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-10 19:37:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Scott Dodson 2011-10-11 23:05:56 UTC
SPEC : http://sdodson.fedorapeople.org/drupal7-cck.spec
SRPM : http://sdodson.fedorapeople.org/drupal7-cck-2-0.1.dev.fc15.src.rpm

Description :
The Content Construction Kit allows you to add custom fields to nodes using a
web browser.

Comment 1 Gwyn Ciesla 2011-10-17 14:03:54 UTC
Good:

- rpmlint checks return:

Nothing.

- package meets naming guidelines
- package meets packaging guidelines
- license ( GPLv2+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

In the future, you might want to make SourceX files like LICENSE.txt named something like drupal7-cck-LICENSE.txt to avoid SRPM clobber.  Otherwise it looks good.

APPROVED.

Comment 2 Scott Dodson 2011-10-28 21:53:30 UTC
New Package SCM Request
=======================
Package Name: drupal7-cck
Short Description: The Content Construction Kit allows you to add custom fields to nodes using a web browser.
Owners: sdodson
Branches: f14 f15 f16 el5 el6
InitialCC:

Comment 3 Gwyn Ciesla 2011-10-29 01:19:26 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2011-11-03 21:02:20 UTC
drupal7-cck-2-0.1.dev.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/drupal7-cck-2-0.1.dev.fc15

Comment 5 Fedora Update System 2011-11-03 21:02:30 UTC
drupal7-cck-2-0.1.dev.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/drupal7-cck-2-0.1.dev.el6

Comment 6 Fedora Update System 2011-11-03 21:02:38 UTC
drupal7-cck-2-0.1.dev.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/drupal7-cck-2-0.1.dev.el5

Comment 7 Fedora Update System 2011-11-03 21:02:50 UTC
drupal7-cck-2-0.1.dev.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/drupal7-cck-2-0.1.dev.fc16

Comment 8 Fedora Update System 2011-11-03 21:02:58 UTC
drupal7-cck-2-0.1.dev.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/drupal7-cck-2-0.1.dev.fc14

Comment 9 Fedora Update System 2011-11-04 20:00:39 UTC
drupal7-cck-2-0.1.dev.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 10 Fedora Update System 2011-12-10 19:37:28 UTC
drupal7-cck-2-0.1.dev.fc14 has been pushed to the Fedora 14 stable repository.

Comment 11 Fedora Update System 2011-12-10 19:44:31 UTC
drupal7-cck-2-0.1.dev.fc16 has been pushed to the Fedora 16 stable repository.

Comment 12 Fedora Update System 2011-12-10 19:48:49 UTC
drupal7-cck-2-0.1.dev.fc15 has been pushed to the Fedora 15 stable repository.

Comment 13 Fedora Update System 2011-12-10 21:25:35 UTC
drupal7-cck-2-0.1.dev.el5 has been pushed to the Fedora EPEL 5 stable repository.

Comment 14 Fedora Update System 2011-12-10 21:29:41 UTC
drupal7-cck-2-0.1.dev.el6 has been pushed to the Fedora EPEL 6 stable repository.