Bug 745383

Summary: Review request: rubygem-shindo - Simple depth first Ruby testing
Product: [Fedora] Fedora Reporter: Bohuslav "Slavek" Kabrda <bkabrda>
Component: Package ReviewAssignee: Vít Ondruch <vondruch>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: notting, package-review, tdawson, vondruch
Target Milestone: ---Flags: vondruch: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-10-14 06:04:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Bohuslav "Slavek" Kabrda 2011-10-12 08:12:53 UTC
SPEC: http://bkabrda.fedorapeople.org/shindo/rubygem-shindo.spec
SRPM: bkabrda.fedorapeople.org/shindo/rubygem-shindo-0.3.4-1.fc15.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3424875

Description: Work with your tests, not against them.

Comment 1 Bohuslav "Slavek" Kabrda 2011-10-12 08:14:11 UTC
Sorry for the bas SRPM url, here it is OK: http://bkabrda.fedorapeople.org/shindo/rubygem-shindo-0.3.4-1.fc15.src.rpm

Comment 2 Vít Ondruch 2011-10-12 12:41:24 UTC
I'll take this one for review

Comment 3 Vít Ondruch 2011-10-12 12:56:58 UTC
* The test suite execution could be simplified
  - It should be enough to run the test suite using command 'bin/shindo' that
    is it. The way you proposed looks overly complicated.

Since this is the only nit and has no influence on anything, the package is APPROVED.

Comment 4 Bohuslav "Slavek" Kabrda 2011-10-13 06:20:02 UTC
New Package SCM Request
=======================
Package Name: rubygem-shindo
Short Description: Simple depth first Ruby testing
Owners: bkabrda
Branches: 
InitialCC:

Comment 5 Gwyn Ciesla 2011-10-13 12:44:45 UTC
Git done (by process-git-requests).

Comment 6 Troy Dawson 2014-12-18 23:35:41 UTC
Package Change Request
======================
Package Name: rubygem-shindo
New Branches: epel7
Owners: tdawson

Comment 7 Gwyn Ciesla 2014-12-19 13:28:53 UTC
Git done (by process-git-requests).