Bug 745677

Re-assigning to CS team, they own /usr/bin/pkicreate.

I would like to see this fixed in 6.2 :-)

The pki-create script appears to have a "config.desktop" file that is installed:

    # Linux required desktop files
    $setup_config_area = "/usr/share/applications";
    $setup_config_name = "config.desktop";

This config.desktop file contains the firefox launcher URL.  We generate the config.desktop files from "config.desktop.in" templates for each subsystem.  These templates are in the source tree under the "pki/base/<subsystem>/setup" directories.

To fix this, I would propose the following:

(1) First, move the 'config.desktop.in' files and associated CMake logic
    for building them from their primary PKI component to their
    corresponding PKI-UI component:

    ca/setup/config.desktop.in   --> ca-ui/setup/config.desktop.in
    kra/setup/config.desktop.in  --> kra-ui/setup/config.desktop.in
    ocsp/setup/config.desktop.in --> ocsp-ui/setup/config.desktop.in
    ra/setup/config.desktop.in   --> ra-ui/setup/config.desktop.in
    tks/setup/config.desktop.in  --> tks-ui/setup/config.desktop.in
    tps/setup/config.desktop.in  --> tps-ui/setup/config.desktop.in

(2) Fix the "dogtag-pki-theme.spec" (and if ever available,
    "redhat-pki-theme.spec") to INCLUDE the
    "/usr/share/pki/<subsystem>-ui/setup" directories and
    "/usr/share/pki/<subsystem>-ui/setup/config.file" files.

(3) Fix the "ipa-pki-theme.spec" to EXCLUDE the
    "/usr/share/pki/<subsystem>-ui/setup" directories and
    "/usr/share/pki/<subsystem>-ui/setup/config.file" files.

(4) Fix the logic in "pki-create" to first check for the existence of
    a file called "/usr/share/pki/<subsystem>-ui/setup/config.desktop"
    prior to attempting to create an instance of
    "/usr/share/applications/<pki_instance_name>-config.desktop".

This should fix the issue on RHEL 6 since it utilizes the empty
'ipa-pki-theme' packages.

However, this may remain an issue for FreeIPA when attempting to live in
concert with Dogtag PKI (unsure it this is a problem for FreeIPA).

Created attachment 567798 [details]
Remove CA desktop icon

Created attachment 567800 [details]
Remove all other PKI desktop icons

Created attachment 567801 [details]
Apply patch to remove CA desktop icon

After discussions on IRC, it was determined that the desktop icon logic would be removed rather than located to the UI components.  The three previous attachments implement this approach.

# git am  0026-BZ-745677-Remove-CA-desktop-icon.patch
Applying: Remove CA desktop icon

# git log -1
commit 15e6ec8158eff9895b54a163f4031532692322e3
Author: Matthew Harmsen <mharmsen>
Date:   Mon Mar 5 17:16:28 2012 -0800

    Remove CA desktop icon
    
    Bugzilla Bug #745677 - Firefox Launcher on Panel being modified for all user

# git push
Counting objects: 17, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (9/9), 804 bytes, done.
Total 9 (delta 6), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/pki.git
   889694d..15e6ec8  IPA_v2_RHEL_6_ERRATA_BRANCH -> IPA_v2_RHEL_6_ERRATA_BRANCH

# git am 0001-Remove-all-other-PKI-desktop-icons.patch 
Applying: Remove all other PKI desktop icons

# git log -1
commit f6f83148f9dffd35a9226b4e7f8701d66738cb73
Author: Matthew Harmsen <mharmsen>
Date:   Mon Mar 5 17:23:24 2012 -0800

    Remove all other PKI desktop icons
    
    Bugzilla Bug #745677 - Firefox Launcher on Panel being modified for all user

# git push
Counting objects: 21, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (10/10), done.
Writing objects: 100% (11/11), 1.05 KiB, done.
Total 11 (delta 7), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/pki.git
   15e6ec8..f6f8314  IPA_v2_RHEL_6_ERRATA_BRANCH -> IPA_v2_RHEL_6_ERRATA_BRANCH

# git am 0001-Apply-patch-to-remove-CA-desktop-icon.patch
Applying: Apply patch to remove CA desktop icon
/home/mharmsen/DOGTAG/pkigit.ipa/.git/rebase-apply/patch:31: trailing whitespace.
 
/home/mharmsen/DOGTAG/pkigit.ipa/.git/rebase-apply/patch:94: trailing whitespace.
 
/home/mharmsen/DOGTAG/pkigit.ipa/.git/rebase-apply/patch:102: trailing whitespace.
 
/home/mharmsen/DOGTAG/pkigit.ipa/.git/rebase-apply/patch:112: trailing whitespace.
 
/home/mharmsen/DOGTAG/pkigit.ipa/.git/rebase-apply/patch:114: trailing whitespace.
 
warning: squelched 3 whitespace errors
warning: 8 lines add whitespace errors.

# git log -1
commit f1e0c039172512389dddf51372411b5799fc6c5c
Author: Matthew Harmsen <mharmsen>
Date:   Mon Mar 5 18:14:33 2012 -0800

    Apply patch to remove CA desktop icon
    
    Bugzilla Bug #745677 - Firefox Launcher on Panel being modified for all user

# git push
Counting objects: 8, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (5/5), 2.46 KiB, done.
Total 5 (delta 2), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/pki.git
   f6f8314..f1e0c03  IPA_v2_RHEL_6_ERRATA_BRANCH -> IPA_v2_RHEL_6_ERRATA_BRANCH

Forgot to add spec file:

# git push
Counting objects: 9, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (5/5), 684 bytes, done.
Total 5 (delta 3), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/pki.git
   f1e0c03..f70660c  IPA_v2_RHEL_6_ERRATA_BRANCH -> IPA_v2_RHEL_6_ERRATA_BRANCH

VERIFIED.

===========================================================
[root@dhcp201-219 ~]# cat /etc/redhat-release ; arch
Red Hat Enterprise Linux Server release 6.3 Beta (Santiago)
x86_64
[root@dhcp201-219 ~]# 
===========================================================

Version Info:
===========================================================
[root@dhcp201-219 ~]# rpm -q pki-ca
pki-ca-9.0.3-24.el6.noarch
[root@dhcp201-219 ~]# 
===========================================================
[root@dhcp201-219 ~]# rpm -q pki-ca --changelog | grep 745677 -A1 -B1
* Mon Mar 05 2012 Matthew Harmsen <mharmsen> 9.0.3-22
- Resolves #745677 - Firefox Launcher on Panel being modified for all users.
  (fixed in Git repo)
[root@dhcp201-219 ~]# 
===========================================================

Launching firefox from the gnome session now does not go to the PKI configuration URL. (which is expected after this bug fix)

Missed to add in the above comment, for the IPA server staus:
===========================================================
[root@dhcp201-219 ~]# ipactl status
Directory Service: RUNNING
KDC Service: RUNNING
KPASSWD Service: RUNNING
DNS Service: RUNNING
MEMCACHE Service: RUNNING
HTTP Service: RUNNING
CA Service: RUNNING
[root@dhcp201-219 ~]# 
===========================================================

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0761.html