Bug 745734

Summary: Check for domain being active on successful job acquire
Product: Red Hat Enterprise Linux 6 Reporter: Michal Privoznik <mprivozn>
Component: libvirtAssignee: Michal Privoznik <mprivozn>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.2CC: acathrow, ajia, jdenemar, mzhan, rwu, weizhan, ydu
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-0.9.4-18.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 11:37:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 748554    
Attachments:
Description Flags
repro.sh none

Description Michal Privoznik 2011-10-13 09:08:04 UTC 
Description of problem:
In libvirt QEMU driver locking whole domain is not desired, esp. during sleeps we came up with so called job conditions. That is, after obtaining lock for domain we try to set a job on it. During setting job, domain might get unlocked, thus its state might get changed. Therefore, after every successful job acquire we need to check if domain is still alive. Okay, there are a few exceptions (e.g. starting a domain). Otherwise, if we don't check we might end up trying to lock/access NULL monitor.

Version-Release number of selected component (if applicable):
libvirt-0.9.4-17.el6

How reproducible:
100%

Steps to Reproduce:
1. run attached reproducer and pass it a domain name
2. observe daemon crash
3.
  
Actual results:
libvirtd crashes


Expected results:
libvirtd will not crash

Additional info:
Comment 1 Michal Privoznik 2011-10-13 09:09:09 UTC 
Created attachment 527909 [details]
repro.sh
Comment 2 Michal Privoznik 2011-10-13 09:16:24 UTC 
Moving to POST:

http://post-office.corp.redhat.com/archives/rhvirt-patches/2011-October/msg00398.html
Comment 6 yanbing du 2011-10-18 09:16:01 UTC 
Bug verified.

rpm packages version:
libvirt-0.9.4-18.el6.x86_64
qemu-kvm-0.12.1.2-2.197.el6.x86_64
kernel-2.6.32-210.el6.x86_64
Comment 7 errata-xmlrpc 2011-12-06 11:37:21 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1513.html