Bug 745952
| Summary: | cxgb4: remove forgotten real_num_tx_queues inicialization | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Jiri Pirko <jpirko> |
| Component: | kernel | Assignee: | Jiri Pirko <jpirko> |
| Status: | CLOSED ERRATA | QA Contact: | Network QE <network-qe> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 6.2 | CC: | atzhang, jpirko, kzhang, nhorman, rkhan |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | kernel-2.6.32-231.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-20 07:57:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 767187 | ||
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Patch(es) available on kernel-2.6.32-231.el6 Verified on kernel-2.6.32-270.el6. netif_set_real_num_tx_queues(dev, pi->nqsets); // this line is removed. Run NIC driver test for cxgb4 kernel-2.6.32-270.el6 and all the tests passed. Set Verified. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2012-0862.html |
Description of problem: following commit: upstream commit a57cabe09f843a3f71277c485494496b3b9ee84a Author: Dimitris Michailidis <dm> Date: Tue Dec 14 21:36:46 2010 +0000 cxgb4: set the number of queues before device registration The number of queues is known early, move the calls to netif_set_real_num_[rt]x_queues before register_netdev. Was backpored as part of rhel commit b661ac107541c93bc70f4373cfdabaebaea07358 but first hunk was missed. Now it causes no problem because the value is same as previously correctly set up in init_one. But in the future this might cause issues if value gets changed only on one place. So just add the missing hunk to remove the line.