Bug 746295

Summary: virt-make-fs doesn't set partition ID
Product: [Community] Virtualization Tools Reporter: Richard W.M. Jones <rjones>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED UPSTREAM QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: mbooth, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-10-21 15:03:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Richard W.M. Jones 2011-10-14 17:20:16 UTC 
Description of problem:

virt-make-fs should set the partition ID (for MBR, or whatever
the equivalent is for GPT).  The problem at the moment is that
if you create a filesystem containing FAT or NTFS, then Windows
guests refuse to "see" the filesystem until you manually set
the partition type.

Version-Release number of selected component (if applicable):

1.13.21

How reproducible:

100%

Steps to Reproduce:
1. Use virt-make-fs to create a Windows filesystem.
2. Attach it to a Windows guest.
  
Actual results:

Windows guest doesn't see any content and refuses to mount
the partition, until you set the partition type byte, eg.
setting it to 7 if it's NTFS.

Expected results:

We can't fix Windows, so we have to fix virt-make-fs instead.

Additional info:

Linux naturally doesn't care.
Comment 1 Richard W.M. Jones 2011-10-21 15:03:33 UTC 
Fixed upstream:
http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=0c06d740b77fb9225a0e2bd13dc88b0b88ee87cb