Bug 746339

Summary:	System Validates on the uniqueness of name
Product:	Red Hat Satellite	Reporter:	Bryan Kearney <bkearney>
Component:	API	Assignee:	Bryan Kearney <bkearney>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Garik Khachikyan <gkhachik>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.0.1	CC:	gkhachik, inecas, lzap, mkoci
Target Milestone:	Unspecified
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-08-22 18:01:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	747354

Description Bryan Kearney 2011-10-14 20:29:31 UTC

this is fine, but the uniqueness should be scoped by owner. I could see removing this edit as the is no real business reason for this.

Comment 1 Lukas Zapletal 2011-11-10 11:21:47 UTC

So I changed the check and scoped it by environment. Is this okay? I can imagine a system named the same in preproduction and production.

cc907bc 746339 - System Validates on the uniqueness of name

Comment 2 Garik Khachikyan 2011-11-30 09:07:35 UTC

I would say - to be scoped by org (as entitlements are associating for organization seems).

@Bryan - could you please confirm that?

Comment 4 Garik Khachikyan 2011-11-30 15:35:28 UTC

# REOPEN

The issue still exists for the katello: katello-0.1.116-1.el6.x86_64

Scenario performed:
----
server1 performs: subscription-manager register --name=test --environment=Test ...
server2 performs: subscription-manager register --name=test --environment=Dev ...

(for both the same org is used - ACME_Corporation)

Scenario fails with ActiveRecord exception like:
---

ActiveRecord::RecordInvalid
name: has already been taken
Rendered text template (0.0ms)
Completed 400 Bad Request in 90ms (Views: 0.4ms | ActiveRecord: 2.1ms)

So maybe the DB side has some constraint(s) still there?

Comment 5 Ivan Necas 2011-12-19 11:16:38 UTC

Fix completed in commit 1089b183194d30199132932680ca7ea0a899727e

Comment 6 Garik Khachikyan 2011-12-20 15:34:22 UTC

# REOPEN

Following is the case that again breaks the logic :)

1. subscription-manager register --username admin --password admin --org=ACME_Corporation --environment=dev
2. subscription-manager register --username admin --password admin --org=EMEA_Corporation --environment=dev

(so same env name, different orgs - which is quite possible case)

packages:
katello-0.1.148-1.git.0.0b9ff7d.el6.noarch
subscription-manager-0.98.3-1.el6.x86_64

(and the case with different env names in one org - is fixed now)

Comment 7 Garik Khachikyan 2011-12-20 15:48:16 UTC

heh. donno why , but it works now ... was unable to reproduce my "issue" - so fixed. :)

Comment 8 Garik Khachikyan 2011-12-20 15:49:03 UTC

# VERIFIED

and verified.

Comment 11 Mike McCune 2013-08-16 18:21:37 UTC

getting rid of 6.0.0 version since that doesn't exist