Bug 746368

two issues found. Please fix

missing build dependancy: openssl-devel

It installs a file /usr/share/doc/COPYING.  This is very generic
and should not be installed there, or use a specific name like
COPYING-dnssec-nodes.

Note an F-14 branch cannot be requested unless dnssec-tools-libs there
is bumped from 1.10 to 1.11.

MUST items:

* OK: Complies to package nameing guidlines
* OK: matches base package
* OK: Meets package guidelines
* OK: Valid license BSD matches source code
* OK: Written in Americanized engish as required (sadly)
* OK: COPYING packaged in %doc
* OK: spec file legible
* OK: source matches upstream source
* OK: package compiles and builds on main architecture
* FAIL: buildrequires missing openssl-devel and desktop-file-utils
* OK: no bad locale handling
* OK: no libraries, no ldconfig calls in post/postun
* OK: not relocatable
* OK: does not create or need to own directories
* OK: no duplicate files listed
* OK: Does not bundle other libraries
* OK: macro use consistent
* OK: package contains code or permissable content
* OK: no large document files
* OK: no header files in base package
* OK: no static libraries
* OK: no .so files in base package
* OK: no devel package dependancy issues
* OK: package does not contain .la files
* OK: gui dnssec-nodes.desktop properly installed with desktop-file-install
* FAIL: Packages must not own files or directories already owned by other
  packages. Though this is not true, the file /usr/share/doc/COPYING is too
  generic and could cause issues with other packages
* OK: filenames are valid UTF-8

SHOULD items:

* Packager should bug upstream about license file (packager IS upstreams,
  go twist their rubber arm)
* No translation of description/summary in other languages available
* Reviewer tested build in mock and found missing BuildRequires
* no scriplets present
* no subpackages present
* no pkgconfig present
* no outside file dependancies
* WARN: missing man page for dnssec-nodes  Encourage upstream to write one :)

Personal: I would use "install" or "cp" over %{_cp}

For your upstream hat:
for upstream:
* Add COPYING file (maintainer copied it in)
* make clean does not remove dnssec-nodes
* add man page for dnssec-nodes
* there is a bogus softlink stest -> /home/hardaker/tmp/h/somewhere


rpmlint:

dnssec-nodes.src: W: spelling-error %description -l en_US libval -> lib val, lib-val, Libava
dnssec-nodes.x86_64: W: spelling-error %description -l en_US libval -> lib val, lib-val, Libava
dnssec-nodes.x86_64: W: no-manual-page-for-binary dnssec-nodes
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

Re COPYING: You're right, of course.  I thought _docdir pointed to the package specific directory for some silly reason.  Moving the file to _docdir/%{name}-%{version} where it should be.  The upstream will, indeed, be creating new COPYING and README files for the smaller packages (like dnssec-nodes), but it wasn't the original intent of this release (they were an after-thought, in *part* to make the fedora packages possible).

build reqs: added, thanks

Switched to using __install

FYI:
- adding make clean may be tricky since that's really the job of qmake; I bet it's possible through hacks though.
- man page: will do at some point

(new srpm and spec shortly)

Spec URL: http://www.hardakers.net/temp/dnssec-nodes.spec
SRPM URL: http://www.hardakers.net/temp/dnssec-nodes-1.11.p1-2.fc15.src.rpm

(new copies after fixing above issues)

dnssec-nodes.src: W: file-size-mismatch dnssec-nodes-1.11.p1.tar.gz = 68203, https://www.dnssec-tools.org/download/dnssec-nodes-1.11.p1.tar.gz = 53728

hmm changed released source on me? (I hope it was not malicious, please verify)

diff -Naur a/dnssec-nodes-1.11.p1/dnssec-nodes.pro.user b/dnssec-nodes-1.11.p1/dnssec-nodes.pro.user
diff -Naur a/dnssec-nodes-1.11.p1/dnssec-nodes.pro.user.2.3pre1 b/dnssec-nodes-1.11.p1/dnssec-nodes.pro.user.2.3pre1
diff -Naur a/dnssec-nodes-1.11.p1/exif-info.db b/dnssec-nodes-1.11.p1/exif-info.db
diff: a/dnssec-nodes-1.11.p1/stest: No such file or directory
diff -Naur a/dnssec-nodes-1.11.p1/.thumbnails/thumb-0 b/dnssec-nodes-1.11.p1/.thumbnails/thumb-0
diff -Naur a/dnssec-nodes-1.11.p1/.thumbnails/thumbnailindex b/dnssec-nodes-1.11.p1/.thumbnails/thumbnailindex

I think this was mostly to correct the bad "stest" softlink, but other things changed too. Maybe bump to 1.11.p2 ?

The COPYING file issue and openssl-devel buildrequires  has been resolved.

If you can confirm the version tar ball change, this package is good to go

The source package was updated to include a man page, a COPYING file and is now version .p2.

http://www.hardakers.net/temp/dnssec-nodes-1.11.p2-1.fc15.src.rpm
http://www.hardakers.net/temp/dnssec-nodes.spec

Tested and confirmed. assuming the other 3 related packages will not get the name "DNS Visualization tool", this package is APPROVED

New Package SCM Request
=======================
Package Name: dnssec-tools
Short Description: DNS Visualization Tool
Owners: hardaker
Branches: f14 f15 f16 el6

Paul, please take ownership if review BZs.

The package name in the SCM request doesn't match the subject or the URLs.

New Package SCM Request
=======================
Package Name: dnssec-nodes
Short Description: DNS Visualization Tool
Owners: hardaker
Branches: f14 f15 f16 el6

(whoops; typo in the original request.  Sorry)

Git done (by process-git-requests).

NP, thanks!

dnssec-nodes-1.11.p2-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/dnssec-nodes-1.11.p2-1.fc15

dnssec-nodes-1.11.p2-1.fc15 has been pushed to the Fedora 15 testing repository.

dnssec-nodes-1.11.p2-1.fc15 has been pushed to the Fedora 15 stable repository.