| Summary: | Review Request: dnssec-check - A tool to check DNSSEC capabilities of the local DNS resolvers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Wes Hardaker <wjhns174> |
| Component: | Package Review | Assignee: | Paul Wouters <pwouters> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bct, notting, package-review, pwouters |
| Target Milestone: | --- | Flags: | pwouters:
fedora-review+
jkeating: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | dnssec-check-1.11.p2-1.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-11-25 02:06:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Wes Hardaker
2011-10-17 20:55:43 UTC
http://www.hardakers.net/temp/dnssec-check-1.11.p2-1.fc15.src.rpm http://www.hardakers.net/temp/dnssec-check.spec Updated to the upstream 1.11.p2 to add a man page and COPYING file and fix the .desktop file. Note on the spec file, it contains a spelling mistake in the %description 'mechanism'. Didn't find any issues that apply to current Fedora version. Mock build completed successfully. Ben: thanks; I've fixed that in my local copy. for upstream: mainwindow.cpp: In member function 'void MainWindow::getAnswers()': mainwindow.cpp:247:57: warning: deprecated conversion from string constant to 'char*' rpmlint: [paul@bofh paul]$ rpmlint /home/paul/SRPMS/dnssec-check-1.11.p2-1.fc14.src.rpm /home/paul/RPMS/x86_64/dnssec-check-1.11.p2-1.fc14.x86_64.rpm/home/paul/RPMS/x86_64/dnssec-check-1.11.p2-1.fc14.x86_64.rpm /home/paul/RPMS/x86_64/dnssec-check-debuginfo-1.11.p2-1.fc14.x86_64.rpm dnssec-check.src: W: spelling-error %description -l en_US mechansim -> mechanism (none): E: no installed packages by name /home/paul/RPMS/x86_64/dnssec-check-1.11.p2-1.fc14.x86_64.rpm/home/paul/RPMS/x86_64/dnssec-check-1.11.p2-1.fc14.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 1 warnings. MUST items: * OK: Complies to package nameing guidlines * OK: matches base package * OK: Meets package guidelines * OK: Valid license BSD matches source code * OK: Written in Americanized engish as required * OK: COPYING packaged in %doc * OK: spec file legible * OK: source matches upstream source * OK: package compiles and builds on main architecture * OK: buildrequires good, rebuilds in mock * OK: no bad locale handling * OK: no libraries, no ldconfig calls in post/postun * OK: not relocatable * OK: does not create or need to own directories * OK: no duplicate files listed * OK: Does not bundle other libraries * OK: macro use consistent * OK: package contains code or permissable content * OK: no large document files * OK: no header files in base package * OK: no static libraries * OK: no .so files in base package * OK: no devel package dependancy issues * OK: package does not contain .la/.a files * OK: gui dnssec-check.desktop properly installed with desktop-file-install * OK: Packages must not own files or directories already owned by other packages. * OK: filenames are valid UTF-8 SHOULD items: * No translation of description/summary in other languages available * Reviewer tested build in mock and found no missing BuildRequires * no scriplets present * no subpackages present * no pkgconfig present * no outside file dependancies * WARN: missing man page for dnssec-nodes Encourage upstream to write one :) PASS New Package SCM Request ======================= Package Name: dnssec-check Short Description:A tool to check DNSSEC capabilities of the local DNS resolvers Owners: hardaker Branches: f14 f15 f16 el6 Git done (by process-git-requests). dnssec-check-1.11.p2-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/dnssec-check-1.11.p2-1.fc16 dnssec-check-1.11.p2-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/dnssec-check-1.11.p2-1.fc14 dnssec-check-1.11.p2-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/dnssec-check-1.11.p2-1.fc15 dnssec-check-1.11.p2-1.fc16 has been pushed to the Fedora 16 testing repository. dnssec-check-1.11.p2-1.fc16 has been pushed to the Fedora 16 stable repository. dnssec-check-1.11.p2-1.fc14 has been pushed to the Fedora 14 stable repository. dnssec-check-1.11.p2-1.fc15 has been pushed to the Fedora 15 stable repository. |