Bug 747003

Summary: Coverity scan results
Product: Red Hat Enterprise Linux 5 Reporter: Michal Luscon <mluscon>
Component: freeradius2Assignee: John Dennis <jdennis>
Status: CLOSED WONTFIX QA Contact: BaseOS QE Security Team <qe-baseos-security>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 5.8CC: kdudka
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-08 16:14:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
patch for radius.c resource leak
none
patch for rlm_perl.c resource leak none

Description Michal Luscon 2011-10-18 14:37:20 UTC
Created attachment 528822 [details]
patch for radius.c resource leak

Coverity scan analyses has revealed an introduction of some newly added defects between RHEL-5.7 and RHEL-5.8 version of freeradius2 package.

#1 - Resource leak on radius.c:862

Static function VAULE_PAIR returns on the line #862 without freeing previously allocated variable tlv.

#2 - Resource leak on rlm_perl.c:428

The same as above one with variable embed.

#3 - Please check missing break on conffile.c:1564. I am not sure whether this break is necessary or not.

You can find my proposed solutions in the attachment section.

Version-Release number of selected component (if applicable):
freeradius2-2.1.12-1.el5

Comment 1 Michal Luscon 2011-10-18 14:42:43 UTC
Created attachment 528823 [details]
patch for rlm_perl.c resource leak