Bug 747031
Summary: | Review Request: ghc-hs-bibutils - Haskell bindings to bibutils, the bibliography conversion utilities | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Teemu Rytilahti <tpr> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | haskell-devel, jude, notting, package-review, petersen |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | NotReady - needs bibutils | ||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-10-01 11:28:49 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Teemu Rytilahti
2011-10-18 15:48:08 UTC
Thanks Teemu, generally your package looks ok. I have a few smaller comments/suggestions: > %global common_summary Haskell bindings to bibutils, the bibliography conversion utilities I think "Haskell bindings to bibutils" is sufficient and succinct enough for the summary. > %global common_description Haskell bindings to Chris Putnam's bibutils, a\ (I would break the line before "a".:) > For more details about bibutils, please check:\ > <http://www.scripps.edu/~cdputnam/software/bibutils/>.\ > The original API documentation is available here:\ > <http://www.scripps.edu/~cdputnam/software/bibutils/library_specs.html>.\ Not sure both the urls are really necessary (people can get to them from the hackage page anyway: personally I would remove the second sentence anyway. > The package release number refers to the release number of \ > the included bibutils library. I think better to remove this. Anyway you are pretty free to edit the description to your liking. > Release: 0%{?dist} You need to bump this. > License: GPLv2 I see a potential problem here: Bibutils.hsc proclaims itself to be BSD license. Is it because bibutils is GPL that hs-bibutils is saying it is GPL too, or something else? If you are not sure I suggest contacting the maintainer to clarify the license. > # BEGIN cabal2spec : > BuildRequires: ghc-Cabal-devel > BuildRequires: ghc-rpm-macros > BuildRequires: ghc-syb-devel > BuildRequires: ghc-base-prof Actually @DEPENDENCIES@ below is a placeholder for these. So better to place them outside the "cabal2spec" commented block. : > # END cabal2spec : > #BuildRequires: @DEPENDENCIES@ Here! ^ :) > #%define cabal_configure_options -f "opt1 -opt2 ..." You can remove this to get rid of the warning you mentioned: >> ghc-hs-bibutils.src:74: W: macro-in-comment %define > %changelog > * Thu Oct 13 2011 Fedora Haskell SIG <haskell-devel.org> - 4.12-0 > - initial packaging for Fedora automatically generated by cabal2spec-0.24.1 You need to add a comment to document the changes you make each time you update the spec file. First of all, sorry for so late response. I just fixed these issues (hopefully), and as I mentioned in IRC the licensing issue should also be resolved. Citing from a mail from the author: > originally hs-bibutils was shipped separately from bibutils and so, > while the second was and still is GPL, my bindings were BSD. > > Now hs-bibutils comes with an included copy of the bibutils library, and > so I had to change the hs-bibutils' license to GPL in order to comply > with bibutils' requirements. > > In other terms, starting from version 4.12 hs-bibutils is covered by the > GNU GPL too. According to bibutils license file it is licensed (specifically) under GPLv2. Spec URL: http://stetson.frozenhat.fi/~tpr/fedora/ghc-hs-bibutils.spec SRPM URL: http://stetson.frozenhat.fi/~tpr/fedora/ghc-hs-bibutils-4.12-1.fc15.src.rpm Very sorry to sit on this into the New Year... :-( Apologies to ask now but would you be able to update the packaging to current cabal2spec-0.25? It is somewhat simpler and cleaner than 0.24. Do you still want to submit this package? Perhaps it is quicker if I submit? :) I'm commenting on this ticket as per https://bugzilla.redhat.com/show_bug.cgi?id=656892#c11 You may want to use the %gh_files macro to make sure the LICENSE and README file are published at the expected location. I don't know if this macro is available in cabal2spec 0.24, so I would also reiterate comment #3 request to update the packaging to use cabal2spec 0.25.4. An example of using %ghc_files is at http://code.haskell.org/augeas/packaging/rpm/ghc-augeas.spec I noticed now that hs-bibutils embeds a copy of bibutils which is not allowed in Fedora - so I think bibutils would need to be packaged first for Fedora, and then this package should BR: bibutils-devel. *** This bug has been marked as a duplicate of bug 861923 *** |