Bug 747211

Summary:	Anyone can add system Key/Values
Product:	[Retired] Beaker	Reporter:	Raymond Mancy <rmancy>
Component:	inventory	Assignee:	beaker-dev-list
Status:	CLOSED WONTFIX	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	low
Version:	0.7	CC:	bpeck, mcsontos, stl, tools-bugs
Target Milestone:	---	Keywords:	EasyFix, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	Misc
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-10-21 14:15:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Raymond Mancy 2011-10-19 05:32:51 UTC

We currently don't restrict who can add Key/Values to a system, we just hide the 'Add' button. We should add something like:-

  system.can_admin(user)

into def save_keys()

Comment 1 Marian Csontos 2011-10-19 07:42:30 UTC

Is that a bug or a feature?

Majority of keys should be locked, but we could have a "namespace" (prefix?) available for regular users - see Bug 602912.

Comment 2 Raymond Mancy 2011-10-19 22:33:48 UTC

The intent of the interface would make me think it's a bug.

Comment 3 Marian Csontos 2011-10-20 05:17:22 UTC

Yes, I mean bug, but an useful one, often called "undocumented feature".

This could be turned into full fledged feature, but for now it should be fixed I think.