Bug 747470

Summary: Review Request: perl-Devel-CheckLib - Check that a library is available
Product: [Fedora] Fedora Reporter: Jose Pedro Oliveira <jose.p.oliveira.oss>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dwmw2, gwync, notting, package-review, ppisar
Target Milestone: ---Flags: gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-16 20:02:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jose Pedro Oliveira 2011-10-19 23:33:36 UTC
Spec URL:
http://um-pe09-2.di.uminho.pt/fedora/perl-Devel-CheckLib.spec

SRPM URL:
http://um-pe09-2.di.uminho.pt/fedora/perl-Devel-CheckLib-0.94-1.fc15.src.rpm

Description:
Devel::CheckLib is a perl module that checks whether a particular C library
and its headers are available.

Comment 1 Jose Pedro Oliveira 2011-10-23 00:01:56 UTC
New upstream release:
http://um-pe09-2.di.uminho.pt/fedora/perl-Devel-CheckLib-0.95-1.fc15.src.rpm

Comment 2 Marcela Mašláňová 2011-11-15 14:57:03 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
 http://koji.fedoraproject.org/koji/taskinfo?taskID=3515556
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -qp --provides ~/Downloads/perl-Devel-CheckLib-0.95-1.fc16.noarch.rpm 
perl(Devel::CheckLib) = 0.95
perl-Devel-CheckLib = 0.95-1.fc16
rpm -qp --requires ~/Downloads/perl-Devel-CheckLib-0.95-1.fc16.noarch.rpm 
/usr/bin/perl  
perl >= 0:5.00405
perl(:MODULE_COMPAT_5.14.2)  
perl(Config)  
perl(Devel::CheckLib)  
perl(Exporter)  
perl(File::Spec)  
perl(File::Temp)  
perl(Text::ParseWords)  
perl(strict)  
perl(vars)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

APPROVED

Comment 3 Jose Pedro Oliveira 2011-11-15 15:17:40 UTC
New Package SCM Request
=======================
Package Name: perl-Devel-CheckLib
Short Description: Check that a library is available
Owners: jpo
Branches: F15 F16 EL6
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2011-11-15 15:39:36 UTC
Git work should be done, but there was a script error.  I think everything's ok, but re-set the cvs flag and describe the problem if it's not.  Thanks!

Comment 5 Jose Pedro Oliveira 2011-11-15 16:16:16 UTC
(In reply to comment #4)
> Git work should be done, but there was a script error.  I think everything's
> ok, but re-set the cvs flag and describe the problem if it's not.  Thanks!

Jon,

I was able to import and build the package for EL6, F15, F16 and F17 but
I received 4 "Undelivered Mail Returned to Sender" messages (the mail account 
perl-Devel-CheckLib-owner appears to be missing).

/jpo



---------
...
--E618721645.1321371861/pkgs01.phx2.fedoraproject.org
Content-Description: Notification
Content-Type: text/plain; charset=us-ascii

This is the mail system at host pkgs01.phx2.fedoraproject.org.

I'm sorry to have to inform you that your message could not
be delivered to one or more recipients. It's attached below.

For further assistance, please send mail to postmaster.

If you do so, please include this problem report. You can
delete your own text from the attached returned message.

                   The mail system

<perl-Devel-CheckLib-owner>: host bastion[10.5.126.12] said:
    550 5.1.1 <perl-Devel-CheckLib-owner>: Recipient address
    rejected: User unknown in local recipient table (in reply to RCPT TO
    command)

--E618721645.1321371861/pkgs01.phx2.fedoraproject.org
Content-Description: Delivery report
Content-Type: message/delivery-status

Reporting-MTA: dns; pkgs01.phx2.fedoraproject.org
X-Postfix-Queue-ID: E618721645
X-Postfix-Sender: rfc822; jpo
Arrival-Date: Tue, 15 Nov 2011 15:44:20 +0000 (UTC)

Final-Recipient: rfc822; perl-Devel-CheckLib-owner
Action: failed
Status: 5.1.1
Remote-MTA: dns; bastion
Diagnostic-Code: smtp; 550 5.1.1 <perl-Devel-CheckLib-owner>:
    Recipient address rejected: User unknown in local recipient table
...
--------

Comment 6 Gwyn Ciesla 2011-11-15 16:28:33 UTC
That takes awhile to populate at times.  I get that if I commit and build right after repo creation.

Comment 7 Jose Pedro Oliveira 2011-11-15 17:19:25 UTC
(In reply to comment #6)
> That takes awhile to populate at times.  I get that if I commit and build right
> after repo creation.

Thanks for the explanation.

/jpo

Comment 8 Jose Pedro Oliveira 2011-11-16 20:02:37 UTC
Marcela: Thanks for the review.

Closing: RPMS already in the {F15, F16, EL6} testing repositories.