Bug 747898

Summary:	'Enter' and 'Ctrl+Enter' keyboard shortcuts do not shift focus if 'Next Entry' is chosen in the navigation settings
Product:	[Retired] Zanata	Reporter:	Runa Bhattacharjee <runab>
Component:	Usability	Assignee:	Alex Eng <aeng>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ding-Yi Chen <dchen>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.4	CC:	ankit, sflaniga, zanata-bugs
Target Milestone:	---
Target Release:	1.4.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-10-28 07:02:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	743789, 748696

Description Runa Bhattacharjee 2011-10-21 10:33:33 UTC

Description of problem:

In the newly added settings for navigation, selecting the last item in the drop down 'next entry' partially disables the 'Enter' (if selected) and 'Ctrl+Enter' keyboard shortcuts. These shortcuts allow the users to save the current entry and to move to the next entry. However, in this case the current entry gets saved, but the focus remains on the cell when 'Enter' (if selected) or 'Ctrl+Enter' is used.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Login to Zanata and navigate to a project of your choice. Open a file in the web editor

2. Using the settings icon on the navigation panel, select 'Enter' key saves immediately' and 'Navigation key/button options:'=>'Next Entry'

3. Start editing an entry and click 'Enter' or 'Ctrl+Enter' to save that entry. 
  
Actual results:

The entry is saved, but the focus remains on the entry

Expected results:

The entry is saved and the focus moves to the next entry

Additional info:

Ideally the 'Next Entry' option should not be present in the dropdown. It already has an exclusive button on the navigation panel.

Comment 1 Ding-Yi Chen 2011-10-24 00:06:43 UTC

This behaviour is observed with Zanata version 1.4.2-SNAPSHOT (20111021-1207)

Comment 2 Sean Flanigan 2011-10-24 02:44:06 UTC

The reason "Next Entry" is in the dropdown is so that Enter/Ctrl-Enter can support the new modal navigation feature and still have the ability to go simply to the next row.  But obviously you've found a bug with that.  

But even if that feature were working, it doesn't seem to be well liked, so we can just take it out of the dropdown, and Enter/Ctrl-Enter will just go to the next row, as before.

Comment 3 Alex Eng 2011-10-24 04:38:02 UTC

Remove 'Next Entry' option from shortcut config. 
CTRL+Enter / Enter in editor move to next entry.

Fix bug:
https://github.com/zanata/zanata/commit/93783eb1f946be35c8ad65f2f6dc608b4df8ddff

Comment 4 Ding-Yi Chen 2011-10-24 06:56:37 UTC

With Zanata version 1.4.2-SNAPSHOT (20111024-1450)

As expected:
The 'Next Entry' is removed.
Ctrl-Enter/ (Enter) moved to next entry.

However, now Ctrl-Enter /Enter does not change the NeedReview entries to Approved.

Thus, this bug is re-ASSIGNED.

Comment 5 Alex Eng 2011-10-24 23:56:27 UTC

Bug reported on Comment 4 fixed. See https://github.com/zanata/zanata/commit/dbe977e2c9d3f6d409dd3fab312d9f989f954445

Comment 6 Ding-Yi Chen 2011-10-26 03:43:51 UTC

VERIFIED with Zanata version 1.4.2-SNAPSHOT (20111025-0954)