| Summary: | Do not define HAVE_BAUDBOY when building C-Kermit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jiri Popelka <jpopelka> | ||||
| Component: | ckermit | Assignee: | Eric Smith <spacewar> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | spacewar | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-11-09 21:53:31 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
I think you can also change the URL from http://www.columbia.edu/kermit/ck90.html (see the note on top of this page) to http://www.kermitproject.org/ck90.html Created attachment 529502 [details] removing superflous checking for baudboy.h Because Fedora/RHEL has been the only disto using this baudboy.h it should be safe to remove the baudboy.h checking in upstream code. I have this patch but I haven't found any way how to send it to upstream (I don't see anything on the project's page). So if you know how to contact the developers you could do that for me. The cover letter to the patch would be something like this: " The makefile is checking for existence of /usr/include/baudboy.h and defines HAVE_BAUDBOY if it finds one. Fedora and RHEL linux distributions have been the only places where baudboy.h can be found. Future versions of Fedora/RHEL will be using lockdev-1.0.4 which doesn't contain this header file (there's only ttylock.h) anymore. So it should be safe to remove the baudboy.h checking. see also http://lists.alioth.debian.org/pipermail/lockdev-devel/2010-April/000068.html " Thanks for the useful information. I'll be happy to make the change and to send the information you provided upstream. Can this change be made in Fedora 14 through 16 also, or only for Fedora 17? The makefile seems to define the HAVE_BAUDBOY itself, so yes, you can change it in other branches too, but it's not necessary. Fixed in ckermit-9.0.302-1 in rawhide. |
Description of problem: C-Kermit requires lockdev utility. Lockdev has had new upstream for almost 2 year now. They merged all patches from various distros and done many other changes. The most important for you is that lockdev-devel in Fedora-17 no longer contains baudboy.h so you need to use ttylock.h directly instead of baudboy.h The only thing you need to change in order to successfully build C-Kermit with new lockdev-devel version is to not define HAVE_BAUDBOY when building C-Kermit. diff --git a/ckermit.spec b/ckermit.spec @@ -43,7 +43,7 @@ communication tasks. %build %{__make} linux \ - KFLAGS="-O0 $RPM_OPT_FLAGS -Wall -DOPENSSL_097 -Dsdata=s_data -DHAVE_BAUDBOY -DHAVE_OPENPTY -D'krb5_init_ets(__ctx)='" \ + KFLAGS="-O0 $RPM_OPT_FLAGS -Wall -DOPENSSL_097 -Dsdata=s_data -DHAVE_OPENPTY -D'krb5_init_ets(__ctx)='" \ K4LIB= \ K4INC= \ K5LIB=-lutil \