Bug 747935

Summary:	`product create` (no params): wrong parameter: "--prov"
Product:	Red Hat Satellite	Reporter:	Garik Khachikyan <gkhachik>
Component:	katello-agent	Assignee:	Martin Bacovsky <mbacovsk>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Garik Khachikyan <gkhachik>
Severity:	low	Docs Contact:
Priority:	low
Version:	6.0.0	CC:	mkoci
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-08-22 18:02:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	747354

Description Garik Khachikyan 2011-10-21 12:50:28 UTC

Description of problem:
calling "product create" (without any options) brings to the output with listing an option called: "--prov". Should be: "--provider"

Version-Release number of selected component (if applicable):
Latest: katello-cli-0.1.10-1.git.724.8ac2ca4.el6.noarch

How reproducible:
always

Steps to Reproduce:
1. call product create
2.
3.
  
Actual results:
output with: "--prov" there

Expected results:
output about "--provider"

Additional info:

Comment 1 Martin Bacovsky 2012-01-11 17:24:36 UTC

I was unable to reproduce it with current tree. It seems it was already fixed by the following commit

 $ git log -1 aa53a1

 commit aa53a1e92b60400a6bc2e66249533ede08ffeb49
 Author: Tomas Strachota <tstrachota>
 Date:   Wed Nov 2 18:59:29 2011 +0100

    cli - support for multiline description of commands

 $ git diff aa53a1^..aa53a1 src/katello/client/cli/base.py

diff --git a/cli/src/katello/client/cli/base.py b/cli/src/katello/client/cli/base.py
index f6dfaf7..e266f10 100644
--- a/cli/src/katello/client/cli/base.py
+++ b/cli/src/katello/client/cli/base.py
@@ -76,9 +76,19 @@ class KatelloCLI(object):
         lines = [self.usage_line,
                  'Supported Commands:']
         for name, command in sorted(self._commands.items()):
-            lines.append('\t%-14s %-25s' % (name, command.description))
+            lines += self.__build_command_usage_lines(command)
         return '\n'.join(lines)
 
+    def __build_command_usage_lines(self, command):
+        lines = []
+        desc_lines = command.description.split("\n")
+
+        lines.append('\t%-14s %s' % (command.name, desc_lines.pop(0)) )
+        for l in desc_lines:
+            lines.append('\t%-14s %s' % (" ", l) )
+            
+        return lines
+
     def add_command(self, name, command):
         """
         Add a command to this command line tool

Comment 4 Garik Khachikyan 2012-02-01 09:09:42 UTC

# VERIFIED

Following scenario does displays --provider now.

---
katello -uadmin -padmin product create
Usage: katello [options]

katello: errors:
1) Option --provider is required; please see --help
2) Option --name is required; please see --help

checked against following packages:
---
katello-0.1.207-1.git.0.1fbec20.el6.noarch
katello-cli-0.1.49-1.git.0.6962a71.el6.noarch
pulp-0.0.263-1.el6.noarch
candlepin-0.5.8-1.el6.noarch