Bug 748017
| Summary: | Review Request: lookup - A graphical tool to search DNS for answers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Wes Hardaker <wjhns174> |
| Component: | Package Review | Assignee: | Paul Wouters <pwouters> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, pwouters |
| Target Milestone: | --- | Flags: | pwouters:
fedora-review+
jkeating: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-28 15:23:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Wes Hardaker
2011-10-21 17:50:15 UTC
New copies to fix an include path problem: Spec URL: http://www.hardakers.net/temp/lookup.spec SRPM URL: http://www.hardakers.net/temp/lookup-1.11-2.fc15.src.rpm Spec URL: http://www.hardakers.net/temp/lookup.spec SRPM URL: http://www.hardakers.net/temp/lookup-1.11-3.fc15.src.rpm Removes the reference to the Requires: line that is auto-determined. http://www.hardakers.net/temp/lookup-1.11.p2-1.fc15.src.rpm http://www.hardakers.net/temp/lookup.spec Updated to the upstream 1.11.p2 to add a man page and COPYING file and fix the .desktop file. cd src/ && make -f Makefile install make[1]: Entering directory `/vol/home/paul/BUILD/lookup-1.11.p2/src' install -m 755 -p "build/lookup" "/home/paul/BUILDROOT/lookup-1.11.p2-1.fc14.x86_64/usr/bin/lookup" install -m 644 -p /vol/home/paul/BUILD/lookup-1.11.p2/src/lookup.desktop /home/paul/BUILDROOT/lookup-1.11.p2-1.fc14.x86_64/usr/share/applications/hildon/ install -m 644 -p /vol/home/paul/BUILD/lookup-1.11.p2/data/maemo/lookup.xpm /home/paul/BUILDROOT/lookup-1.11.p2-1.fc14.x86_64/usr/share/pixmap/ install -m 644 -p /vol/home/paul/BUILD/lookup-1.11.p2/data/48x48/lookup.png /home/paul/BUILDROOT/lookup-1.11.p2-1.fc14.x86_64/usr/share/icons/hicolor/48x48/apps/ install -m 755 -p build/lookup "build/"/usr/bin/lookup install: cannot create regular file `build//usr/bin/lookup': No such file or directory make[1]: [install] Error 1 (ignored) That's for your upstream hat though, it seems to cause no issues for the package Huh, odd. Thanks. I'll go hunt that one down. It looks like an odd double install problem. http://www.hardakers.net/temp/lookup-1.11.p2-2.fc15.src.rpm http://www.hardakers.net/temp/lookup.spec These fix the double-install problem (with a broken DESTDIR for one) All issues fixed. PASS note for upstream: lookup.cpp: In member function 'void Lookup::createMenus()': lookup.cpp:233:14: warning: unused variable 'results' lookup.cpp:234:14: warning: unused variable 'submitResults' lookup.cpp: In member function 'void Lookup::init_libval()': lookup.cpp:263:42: warning: deprecated conversion from string constant to 'char*' Oops. forgot to include my checklist
[paul@bofh paul]$ rpmlint /home/paul/SRPMS/lookup-1.11.p2-2.fc14.src.rpm /home/paul/RPMS/x86_64/lookup-1.11.p2-2.fc14.x86_64.rpm /home/paul/RPMS/x86_64/lookup-debuginfo-1.11.p2-2.fc14.x86_64.rpm
lookup.x86_64: W: manual-page-warning /usr/share/man/man1/lookup.1.gz 2: warning: macro `UC' not defined
lookup.x86_64: W: manual-page-warning /usr/share/man/man1/lookup.1.gz 3: warning: macro `SH' not defined
lookup.x86_64: W: manual-page-warning /usr/share/man/man1/lookup.1.gz 10: warning: macro `PP' not defined
lookup.x86_64: W: manual-page-warning /usr/share/man/man1/lookup.1.gz 13: warning: macro `IP' not defined
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
MUST: rpmlint OK
MUST: package name OK
MUST: The spec file name matches the base package
MUST: The package meets the Packaging Guidelines .
MUST: License BSD matches the source and fedora guidelines
MUST: LICENSE file included on %doc
MUST: Americanized english used
MUST: spec file legible
MUST: source matches upstream
MUST: compiles successfully
MUST: mock rebuild confirmed build dependancies
MUST: no locale's
MUST: no libraries, no ldconfig needed
MUST: does not bundle system libraries
MUST: nor relocatable
MUST: package owns its own dirs
MUST: no duplicate files in %files
MUST: consistently macro use
MUST: The package contains code
MUST: bi Large documentation files
MUST: %doc does not affect runtime
MUST: no Header files in base
MUST: no Static libraries in base
MUST: OK no libraries
MUST: no devel pacakge
MUST: no .la or .a files
MUST: Packages include proper %{name}.desktop file, and is installed properly with desktop-file-install in the %install section.
MUST: Packages does not own files or directories already owned by other packages.
MUST: All filenames in rpm packages are valid UTF-8
New Package SCM Request ======================= Package Name: lookup Short Description:A graphical tool to search DNS for answers Owners: hardaker Branches: f14 f15 f16 el6 Git done (by process-git-requests). Wes forgot to close the review bug |