Bug 748082

Summary: udev update triggered problem with udev rules for nqc and/or nxt_python
Product: [Fedora] Fedora Reporter: Bruno Wolff III <bruno>
Component: nxt_pythonAssignee: Martin Langhoff <martin>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: bruno, harald, jonathan, kay, martin, udev-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-10-22 15:23:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
This is with nqc and nxt_python uninstalled
none
Output with nqc and nxt_python installed none

Description Bruno Wolff III 2011-10-22 00:02:01 UTC
Description of problem:
After rebooting today many files in /dev were group owned by 'lego' that shouldn't have been and were set to mode 660 that shouldn't have been. Notably /dev/null was not accessible to world and neither /dev/random nor /dev/urandom were world readable. This prevented X from completing start up.

I looked for references to lego in udev rules and found ones owned by nqc and nxt_python. Removing those two packages got things working again. However those packages haven't changed since last February. Since the udev change triggered the problem I am doing an initial assigment there, since the udev guys are more likely to know what changed and can advise the other package owners if they are doing something wrong.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Kay Sievers 2011-10-22 03:59:05 UTC
The rule in that package doesn't look right, nothing should ever try to
replace a kernel-provided device name with a symlink, but it should not
cause any damage.

What does:
 udevadm test /sys/class/mem/random
print?

Comment 2 Bruno Wolff III 2011-10-22 04:19:21 UTC
Created attachment 529581 [details]
This is with nqc and nxt_python uninstalled

I had removed nqc and nxt_python in order to get things to work on boot. I figured I'd capture the requested output before reinstalling them for comparison. I'll the result with them installed shortly.

Comment 3 Bruno Wolff III 2011-10-22 04:22:12 UTC
Created attachment 529582 [details]
Output with nqc and nxt_python installed

Comment 4 Kay Sievers 2011-10-22 13:11:05 UTC
That looks all fine:
  creating device node '/dev/random', devnum=1:8, mode=0666, uid=0, gid=0

did not notice, that not only nqc but also nxt_python install udev rules.
The rules in nxt_python are broken. SYSFS= and BUS= are deprecated since
years. The rule probably assigns the group 'lego' to all files in /dev.

The rules file needs to move to /lib/udev/rules.d/ and be converted to:
  SUBSYSTEM=="usb", ATTRS{idVendor}=="0694", GROUP="lego", MODE="0660"

Comment 5 Bruno Wolff III 2011-10-22 15:23:53 UTC
Since this bug causes serious issues for rawhide users that have it installed, I invoked provenpackager status to do a fix in rawhide. I'll let the maintainer decide if they want to apply the fix to older versions. There isn't a hurry to do anything with those as the depreciated parameters still work there.

Comment 6 Kay Sievers 2011-10-22 18:16:48 UTC
Thanks for the fix. I'll check if we should ignore such rule lines
entirely, instead of having them match on too many things.

Comment 7 Kay Sievers 2011-10-22 20:42:33 UTC
This should make the broken rules less fatal to the rest of the system, they
should just get ignored now.

http://pkgs.fedoraproject.org/gitweb/?p=udev.git;a=commitdiff;h=4dfe0853b64444e1c5c8f0c7564909ce7b9ed81a

http://koji.fedoraproject.org/koji/taskinfo?taskID=3452144