| Summary: | Review Request: ibus-panel-extensions - Additional UI service components for IBus | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daiki Ueno <dueno> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-01-17 03:10:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Daiki Ueno
2011-10-24 06:56:32 UTC
Review:- + koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3518054 + rpmlint on package gave ibus-panel-extensions.src: W: spelling-error %description -l en_US charmap -> char map, char-map, charm ibus-panel-extensions.src: W: spelling-error %description -l en_US virtkbd -> virtue ibus-panel-extensions.x86_64: W: spelling-error %description -l en_US charmap -> char map, char-map, charm ibus-panel-extensions.x86_64: W: spelling-error %description -l en_US virtkbd -> virtue ibus-panel-extensions-python.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 5 warnings. + source with upstream match as (sha1sum) b6c2b6b853c663f5613038634ba73086b904a279 ibus-panel-extensions-1.4.99.20111021.tar.gz b6c2b6b853c663f5613038634ba73086b904a279 ../SOURCES/ibus-panel-extensions-1.4.99.20111021.tar.gz + package: ibus-panel-extensions-1.4.99.20111021-1.fc17.x86_64 Provides: libibuscharmap.so.0()(64bit) libibusdrawing.so.0()(64bit) libibuspanelextensions.so.0()(64bit) libibusvirtkbd.so.0()(64bit) Requires: libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libeek-gtk.so.0()(64bit) libeek.so.0()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgee.so.2()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgucharmap_2_90.so.7()(64bit) libibus-1.0.so.0()(64bit) libibuscharmap.so.0()(64bit) libibusdrawing.so.0()(64bit) libibuspanelextensions.so.0()(64bit) libibusvirtkbd.so.0()(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libsqlite3.so.0()(64bit) rtld(GNU_HASH) Pacakge: ibus-panel-extensions-devel-1.4.99.20111021-1.fc17.x86_64 Provides: pkgconfig(ibus-charmap) = 1.4.99.20111021 pkgconfig(ibus-drawing) = 1.4.99.20111021 pkgconfig(ibus-panel-extensions) = 1.4.99.20111021 pkgconfig(ibus-virtkbd) = 1.4.99.20111021 Requires: /usr/bin/pkg-config libibuscharmap.so.0()(64bit) libibusdrawing.so.0()(64bit) libibuspanelextensions.so.0()(64bit) libibusvirtkbd.so.0()(64bit) pkgconfig(gobject-2.0) pkgconfig(ibus-panel-extensions) + rest Follows packaging guidelines Suggestions: 1) you don't need following in spec Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig See http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries 2)I see some files and COPYING is GPLv3+ and other files are in GPLv2+ you being the upstream, can you clarify license here? Ping Sorry for being late. I'm going to change the license to LGPLv2+ in upstream to be consistent with ibus core. I'll soon get back to you after the next release including the license change. I finally released a new version and updated the package. It should reflect both of your suggestions 1 and 2. Spec URL: http://ueno.fedorapeople.org/ibus-panel-extensions/ibus-panel-extensions.spec SRPM URL: http://ueno.fedorapeople.org/ibus-panel-extensions/ibus-panel-extensions-1.4.99.20111207-1.fc17.src.rpm Sorry for taking so long. ah! looks like I forgot this to review Looking at SPEC looks ok. APPROVED. ping any progress here? ping oh, I missed comment #5 and #6, sorry. I'll step forward with an SCM request today. New Package SCM Request ======================= Package Name: ibus-panel-extensions Short Description: Additional UI service components for IBus Owners: ueno Branches: f16 f15 InitialCC: i18n-team Git done (by process-git-requests). Thanks. Built in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3707567 |