Bug 748497

Summary:	Wallaby tagging interface: changes to the filtered select widget
Product:	Red Hat Enterprise MRG	Reporter:	Chad Roberts <croberts>
Component:	cumin	Assignee:	Chad Roberts <croberts>
Status:	CLOSED ERRATA	QA Contact:	Daniel Horák <dahorak>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	Development	CC:	dahorak, matt, tmckay
Target Milestone:	2.1
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cumin-0.1.5098-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-01-27 19:12:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Chad Roberts 2011-10-24 15:44:04 UTC

Description of problem:  The layout and functionality of the filtered select widget (used to choose features/hosts for wallaby tags) is suboptimal.  Based on feedback, the following changes need to be made:

1)  Remove the "Unselected" count/link
2)  Move the "Clear" link up next to the input box and make it a button 


How reproducible: 100%


Steps to Reproduce:
1.  Navigate to Grid::Configuration::<choose a tag>::edit hosts or features
2.  Note the filtered select widget
  
Actual results:  The current implementation is awkward, the Unselected count/link is not useful and the clear link seems out of place.


Expected results:
The Unselected count/link should be gone and the clear link should be changed to a button that is to the right of the input box.

Comment 1 Chad Roberts 2011-10-24 18:14:25 UTC

These changes are available in revision 5089 from the trunk.

Comment 2 Chad Roberts 2011-10-25 20:01:43 UTC

Upon further review, revision 5094 on trunk contains the updated version of the widget.

The new functionality is as follows:
1)  There is now an "x" on the right side of the filter box, clicking that x will clear out the filter box and reset the filter.  If you click on the "x" with nothing in the text box, nothing will happen.

2)  There is now a "Select all" checkbox below the filter box.  This checkbox will select all of the items that match the current filter upon checking the box.  If the box is already checked, unchecking it will unselect all of the currently selected items.  
If you change the filter or unselect an item while the "select all" checkbox is checked, it will become unchecked.

Comment 3 Daniel Horák 2011-11-14 12:54:29 UTC

The filter in the filtered select widget (used to choose features/hosts for wallaby tags) don't work correctly (like I except), because when I select (check) some items and then try to find another using the filter, previously selected items that not match with filter are unselected. Is it OK? (I think not.) And is it related to this bug?

e.g.: I like to add features CentralManager and Master.
1. I will select feature CentralManager.
2. I will write 'Master' to the filter box.
3. I will select feature Master.
4. I will clean filter (using 'x' on the right side of the filter box, or via key Backspace, or...)
5. There is only feature Master selected now.

# rpm -q cumin
  cumin-0.1.5098-2.el5

Comment 4 Chad Roberts 2011-11-14 19:34:11 UTC

As discussed on #grid, the behavior described in comment #3 above is what was intended for this release.  There is another BZ 749014 which is where we will be adjusting the functionality for the future.  Any thoughts are welcomed there to help us make the filtered select widget more useful.

Comment 5 Daniel Horák 2011-11-15 08:54:47 UTC

Reproduced on RHEL 6.1 x86_64.
# rpm -q cumin
  cumin-0.1.5068-1.el6.noarch


Verified on RHEL 5.7 i386.
# rpm -q cumin
  cumin-0.1.5098-2.el5

Functionality described in comment 2 behaves correct.

Likewise verified on RHEL 5.7 x86_64, RHEL 6.2 i386 and RHEL 6.2 x86_64.

>>> VERIFIED