Bug 748587

Add some CCs for blocker votes. Please vote!

Is this a regression? I think I've seen the usb stick itself listed in that dialog forever. Never tried to choose it though, maybe anaconda would've disallowed that, but you explicitly state "show" is the problem.

There's also a workaround that can be documented: don't choose the usb stick as target.

-1 blocker
+1 NTH just because this should have been fixed decades ago and this is rather annoying because it brings up the dialogs Adam mentioned in single-disk systems.

there's more to it; this is the easiest way to reproduce, but the USB stick being considered a valid bootloader target can cause ickier stuff, like what I mentioned in my first post. it means anaconda doesn't worry so much about creating a BIOS boot partition on the actual target disk (because the USB stick constitutes a valid stage1 target), and depending on the path you choose, can result in anaconda just dumping the bootloader on the USB stick and not your install disk. which obviously is not what you want.

I can confirm that USB stick is shown as a possible installation target. Just wondering, is there a valid use case where I would like to install Fedora from a stick/hard drive to the *same* media? Is that even possible in Anaconda?
If the use case is nonsense, then +1 to blocker.

That use case is nonsense AFAIK. And anaconda has always *had* code the filter out the USB stick as a possible target, it just got broken. We're not really introducing a new behaviour here. We've always wanted to filter out the stick.

+1 to blocker

so we have four +1 blocker votes, acceptedblocker.

anaconda-16.23-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/anaconda-16.23-1.fc16

Still broken in F16 Final TC3 (Live Desktop).

[liveuser@localhost ~]$ rpm -qa anaconda
anaconda-16.24-2.fc16.x86_64

Let me clarify some of this.

1. Anaconda has never prevented selecting live media disks as boot or
   otherwise
2. If selected, they would not be cleared or repartitioned, but as of
   F16 they could possibly be chosen as the boot disk if one was not
   specified
3. The patch for this bug only prevents selection of live media disks
   when doing custom partitioning. It does not prevent the live media
   disks from appearing in the cleardisks screen (on the left,
   available to move to the right and therefore set as the boot disk)
   in automatic partitioning.

To rework the patch to cover both custom and autopart would be trivial,
but it's up to you to decide if it's too late for that now.


Sandro, if you could tell us what exactly is broken in F16 Final TC3 perhaps we could make some use of that information.

This is the patch to properly fix this on top of what's currently there:

diff --git a/pyanaconda/iw/cleardisks_gui.py b/pyanaconda/iw/cleardisks_gui.py
index 9ab4799..0160be7 100644
--- a/pyanaconda/iw/cleardisks_gui.py
+++ b/pyanaconda/iw/cleardisks_gui.py
@@ -77,7 +77,8 @@ class ClearDisksWindow (InstallWindow):
         # optional in which case neither list would be populated.  Luckily,
         # storage.disks takes isIgnored into account and that handles both thes
         # issues.
-        disks = filter(lambda d: not d.format.hidden, anaconda.storage.disks)
+        disks = filter(lambda d: not d.format.hidden and not d.protected,
+                       anaconda.storage.disks)
 
         self.anaconda = anaconda
 
@@ -162,7 +163,7 @@ class ClearDisksWindow (InstallWindow):
         if self.anaconda.storage.doAutoPart:
             use_disks = self.anaconda.storage.config.clearPartDisks
         else:
-            use_disks = [d.name for d in disks if not d.protected]
+            use_disks = [d.name for d in disks]
             self.addButton.set_sensitive(False)
             self.removeButton.set_sensitive(False)

yeah, I tested the fix for the issue as originally described and I'm pretty sure it's good. I don't think we need to fix it any harder at this point.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Discussed at 2011-10-28 blocker review meeting. The actual blocker issue here ought to be fixed in TC3, we should confirm that and set to VERIFIED. The further issue described by David, which we think is what Sandro saw, we don't consider blocker- or nth-worthy, but if anyone wants to re-consider that, please file a new bug to avoid confusion.

TC3: http://dl.fedoraproject.org/pub/alt/stage/16.TC3/

FWIW: I considered this broken just by being able to select the usb stick and didn't do any more precise tests. That's how I understood the bug...and why I thought this wasn't a regression earlier.

Looks fixed (as fixed as we intended, anyway) in TC3: the live USB is filtered to the left in both 'use all space' and 'create custom layout'.

anaconda 16.24-2 (glibc rebuild) went stable, so CLOSING.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers