Bug 748715

Summary: new VM wizard does not account for disk space changes after 'customize' changes
Product: [Community] Virtualization Tools Reporter: Huming Jiang <hjiang>
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED DEFERRED QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: berrange, crobinso, cwei, mzhan, xen-maint, zpeng
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-01 14:28:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Error dialog1 pop-up
none
Error dialog2 pop-up
none
virt-manager.log none

Description Huming Jiang 2011-10-25 06:26:18 UTC 
Description of the problem:
Use default configuration to create a vm, and make sure you have check the "allocate entire disk now". In the end of creation process, select "customize configuration before install", then "add hardware", select "storage"-> "create a disk image on the computer's hard drive", check " allocate entire disk now". If your disk has 60G size free space, you can allocate 20G size to a added storage, then add three times. Then select one added storage, there will
be some error dialogs pop-up, and cause the vm creation failed.

Version-Release number of selected component (if applicable):
kernel-2.6.32-207.el6.x86_64
qemu-kvm-0.12.1.2-2.196.el6.x86_64
libvirt-0.9.4-19.el6.x86_64
python-virtinst-0.600.0-5.el6.noarch
virt-manager-0.9.0-7.el6.x86_64


Steps to reproduce:
1.#virt-manager --debug
2.Add a new vm with default configuration,and make sure you have check the "allocate entire disk now". Select "customize configuration before install", then finish.(Assume you have more than 8G free size on the disk)
3."add hardware"
4.select "storage"-> "create a disk image on the computer's hard drive",use default size, then finish. Make sure you have check the "allocate entire disk now".(If your disk has 60G size free space, you can allocate 20G size to a added storage, then add three times, until there is no free space on your computer's hard drive.)
5. if your click "disk" or "memory" on the left, there will be an error pop-up.(There should be no error pop-up.)
6. Begin installation, an error pop-up: "Unable to complete install: 'cannot fill file '/var/lib/libvirt/images/a.img': No space left on device'."

Actual results:
"Unable to complete install: 'cannot fill file '/var/lib/libvirt/images/a.img': No space left on device'"

Expected results:
 Assume our disk free size is 61.2G in the new vm installation process, allocate 8G to the vm disk image. After "Customize configuration before install" ,and add a storage hardware, we can see the dialog shows "61.2Gb available in the default location. Actually, only (61.2G - 8G) could be availabe. And maybe this is the solution of this problem.

Addional info:
See the attachment.
Comment 1 Huming Jiang 2011-10-25 06:29:21 UTC 
Created attachment 530010 [details]
Error dialog1 pop-up
Comment 2 Huming Jiang 2011-10-25 06:30:10 UTC 
Created attachment 530011 [details]
Error dialog2 pop-up
Comment 3 Huming Jiang 2011-10-25 06:30:46 UTC 
Created attachment 530012 [details]
virt-manager.log
Comment 5 Cole Robinson 2011-12-09 21:50:41 UTC 
Not urgent, and given reduced capacity for virt-manager/virtinst, just moving this to the upstream tracker.
Comment 6 Cole Robinson 2014-02-01 14:28:36 UTC 
Actually, I'm going to nack this. It's a valid bug, but fixing this in virt-manager is a pain and is in an area of the code that is tough to get completely right. I kind of see this as a case like starting the new VM wizard, then creating a disk image on the command line. The validation step indeed might be out of date when you finally go and kick off the install.

Proper fix would be to statelessly allow duplicating the validation right before starting the install, but that could lose the immediate feedback you get on each page.

Basically if someone showed up with a patch in the right direction I'd help review it and get it applied, but I don't see this being fixed anytime soon.