Bug 748802

Summary: RFE: add a mount plugin
Product: [Fedora] Fedora Reporter: Daniel Mach <dmach>
Component: mockAssignee: Clark Williams <williams>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mebrown, williams
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-21 17:29:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 748824    
Attachments:
Description Flags
a mount plugin patch none

Description Daniel Mach 2011-10-25 12:25:09 UTC
Created attachment 530075 [details]
a mount plugin patch

Sometimes it's useful to mount some devices or nfs shares into a mock chroot.
I wrote a patch that enables this functionality.

If you find any issues with the patch, please let me know so I can fix it.

Comment 1 Clark Williams 2011-11-21 15:52:11 UTC
Just took a quick look at it and it looks nice. Probably won't go into this release (mostly bugfixes) but we can work on getting it into the next one. 

I wonder though, if we shouldn't lift your Mount class into the main mock code and use it to maintain the "standard" mounts (proc, sys, pts, etc.). Then just have the plugin use it? Just a thought.

Comment 2 Daniel Mach 2011-11-28 09:40:38 UTC
(In reply to comment #1) 
> I wonder though, if we shouldn't lift your Mount class into the main mock code
> and use it to maintain the "standard" mounts (proc, sys, pts, etc.). Then just
> have the plugin use it? Just a thought.

I never thought it could be used this way, but yes -- it should work.
Let me know if any changes in the patch are needed...

Comment 3 Clark Williams 2012-02-04 15:32:18 UTC
wups, forgot to add this bug to the latest update. Modified mount.py is now a plugin in mock-1.1.20