| Summary: | Error handling in src/cache.c:ldap_cache_addrdatalist is broken | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Tkac <atkac> |
| Component: | bind-dyndb-ldap | Assignee: | Adam Tkac <atkac> |
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | atkac, ovasik |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-10-31 16:10:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
Description of problem: Error handling in src/cache.c:ldap_cache_addrdatalist is broken. Version-Release number of selected component (if applicable): bind-dyndb-ldap-1.0.0-0.2.b1.fc17 Additional info: The cache->mutex is not unlocked in the following code path due to CHECK() macro. ... if (result == ISC_R_EXISTS) { /* Replace it */ CHECK(dns_rbt_deletename(cache->rbt, name, ISC_FALSE)); goto retry; } else if (result != ISC_R_SUCCESS) { ...