Bug 749258

Summary:	Failed promotion does not leave changeset in good state.
Product:	Red Hat Satellite	Reporter:	Justin Sherrill <jsherril>
Component:	API	Assignee:	Tomas Strachota <tstrachota>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Garik Khachikyan <gkhachik>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.0.0	CC:	cwelton, gkhachik, mkoci, omaciel, tstrachota
Target Milestone:	Unspecified
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	katello-0.1.102-1.git.4.d3ac13e	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-08-22 18:02:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	747354

Description Justin Sherrill 2011-10-26 15:15:23 UTC

If a promotion fails for some reason, we leave the changeset in a 'promoting' state.  Since it has failed though, delayed jobs will not attempt it again, and you can no longer promote any other changesets.  It must be deleted and there is no indication of what went wrong.

Ideally a promotion would never fail, but it does happen on occasion and we need to at least try to handle it.

Comment 1 Tomas Strachota 2011-11-14 20:37:17 UTC

Added new state 'failed' that is set when any exception raises during a promotion. The exception message is saved in changeset's async task status.

commit 8681c878900ab4dab19b7a69fd2317a4a1a79a38
Author: Tomas Strachota <tstrachota>
Date:   Mon Nov 14 19:11:55 2011 +0100

    749258 - new state 'failed' for changesets

Comment 2 Corey Welton 2012-01-11 15:18:29 UTC

Is there any readily apparent set of repro steps for this or should it just be considered a dev task and closed out?

Comment 3 Tomas Strachota 2012-01-11 15:57:38 UTC

Repro steps I can think of could be:
- create a product with a repo and promote it
- create a new changeset and add only the repo
- delete the repo
- try to promote the changeset
- check the changeset's status

Comment 6 Og Maciel 2012-02-28 18:44:54 UTC

Hey Garik! I happened to be working on this area today, and after checking with Tomas, I believe we can close it as validated. Basically, the original issue prevented you from doing anything else via the web ui. Now, one can delete the failed changeset, set it on review and make changes, promote it again, or add a new changeset. Since you got the issue assigned to you I won't close it until you've had a chance to look at it. :)

Comment 7 Garik Khachikyan 2012-02-29 10:14:26 UTC

# VERIFIED

True. Verification done from my side in cli also shows that issue is fixed.