Bug 749346

Summary:

Promotions - Packages - 'add' listed for a package whose repo has not yet been promoted

Product:

Red Hat Satellite

Reporter:

Brad Buckingham <bbuckingham>

Component:

WebUI

Assignee:

Eric Helms <ehelms>

Status:

CLOSED CURRENTRELEASE

QA Contact:

Jeff Weiss <jweiss>

Severity:

low

Docs Contact:

Priority:

unspecified

Version:

6.0.1

CC:

cwelton, dajohnso, ehelms, mmccune, sghai

Target Milestone:

Unspecified

Keywords:

Triaged

Target Release:

Unused

Hardware:

Unspecified

OS:

Linux

Whiteboard:

Fixed In Version:

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2012-08-22 18:03:01 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Attachments:

Description	Flags
no +Add link for fedora packages, as this repo was added later	none

Description Brad Buckingham 2011-10-26 18:53:44 UTC

Description of problem:

Under certain scenarios, the promotions UI will expose the 'add' link for packages whose repository has not yet been promoted.  Based on discussion, the expectation is that before a package can be promoted, the product or repo must first be promoted.  Only once that occurs, should the user be able to promote future packages to the repo.

Version-Release number of selected component (if applicable):
git master

How reproducible:
always

Steps to Reproduce:
1. create provider/product/repo (e.g. spacewalk/spacewalk_product/spacewalk_f14_repo)
2. sync the repo (spacewalk_f14_repo)
3. promote the spacewalk_product
4. add another repo to the above product (e.g. spacewalk_f15_repo)
5. sync the repo (spacewalk_f15_repo)
6. navigate to Content Management -> Promotions
7. create a changeset
8. in the left breadcrumb, navigate to Products -> spacewalk_product -> Packages
  
Actual results:

View that there are packages listed for the spacewalk_f15_repo with an '+Add' link next to them.

Expected results:

There should be no '+Add' link.  

Additional info:

Comment 1 Mike McCune 2012-01-26 19:38:49 UTC

mass move to CFSE product.

Comment 2 Eric Helms 2012-01-30 23:20:44 UTC

64943589b7f125f5d9c662d5306bcae982a8f4aa

This commit merges in a branch where package search is enabled via elasticsearch and brings with it new checks on whether packages are actually promotable to the next environment.  '+Add' showing up under the above scenario should no longer occur.

Comment 3 Mike McCune 2012-03-07 23:44:24 UTC

mass move ON_QA after brewing

Comment 4 Corey Welton 2012-03-09 03:25:09 UTC

Following the scenario above, I am now seeing packages from both repos I created -- in this case, rpmfusion free and rpmfusion free - updates. I promoted the former repo earlier, and as such, each package from that repo reads "Promoted" next to it, versus those from the latter repo.

That said, I don't get +Add for any package, for any repo.

Comment 5 Sachin Ghai 2012-03-20 10:46:51 UTC

Verified with following CFSE build:

[root@perceptor ~]# rpm -qa | grep -ie katello-0 -ie katello-cli-0
katello-0.1.304-1.el6.noarch
katello-cli-0.1.105-1.el6.noarch
[root@perceptor ~]# 


I created product 'pulp' and added 'pulp_64, pulp_86 repos. I synced these repo and promoted the 'pulp' product to next env.

Later, I created pulp_f15 repo under pulp product and synced. Then created a changeset to add the packages from pulp_f15 repo. +Add was not there for pulp_f15 repo packages. Please see the attachment in next comment.

Comment 6 Sachin Ghai 2012-03-20 10:49:00 UTC

Created attachment 571352 [details]
no +Add link for fedora packages, as this repo was added later

Comment 8 Mike McCune 2013-08-16 17:52:40 UTC

getting rid of 6.0.0 version since that doesn't exist