Bug 749706

Summary: Generating Makefile and Publican for non-EAP products does not work as expected
Product: [Community] PressGang CCMS Reporter: Misha H. Ali <mhusnain>
Component: Web-UIAssignee: Matthew Casperson <mcaspers>
Status: CLOSED CURRENTRELEASE QA Contact: Misha H. Ali <mhusnain>
Severity: medium Docs Contact:
Priority: high    
Version: 1.xCC: cbredesen, topic-tool-list
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-07 02:37:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Misha H. Ali 2011-10-28 01:24:51 UTC 
Description of problem:

I just got around to doing a fresh EDG brew and used Matt's text boxes to specific non-EAP parameters for the XML files generated by Skynet. Unfortunately this still has some kinks as the result of the package.sh script is:

Wrote: /home/mishaone/Desktop/Staging/Beta_Documentation/packager/en-US/tmp/rpm/SRPMS/JBoss_Enterprise_Application_Platform-6-web-en-US-2-2.el5.src.rpm

The above is for EAP, while it should contain EDG parameters. I did a quick grep for mentions of "JBoss_Enterprise_Application_Platform" in the generated XML and found the below:

packager/en-US/tmp/rpm/SPECS/JBoss_Enterprise_Application_Platform-6-web-en-US.spec:%define doc_product JBoss_Enterprise_Application_Platform
Binary file packager/en-US/tmp/rpm/SRPMS/JBoss_Enterprise_Application_Platform-6-web-en-US-2-2.el5.src.rpm matches

packager/en-US/Makefile:PRODUCT		= JBoss_Enterprise_Application_Platform

package.sh:	echo "pushd ~/brew-cvs/JBoss_Enterprise_Application_Platform-6-web-en-US/DOCS-RHEL-6"


Additional info:

I thought it fishy that the product value was EAP when the Skynet interface clearly recieved the EDG value from me. Upon inspection, it is this bit in the Makefile that causes that particular snag:

PRODUCT = JBoss_Enterprise_Data_Grid-Beta_Documentation  <-- all correct params
PROD_VERSION = 6
LANG = en-US
BOOKS = Beta_Documentation
VERSION = 1
RELEASE = 51
### START CHANGES ###
PRODUCT		= JBoss_Enterprise_Application_Platform  <--- Back to EAP. 
PROD_VERSION	= 6
LANG		= en-US
BOOKS		= Beta_Documentation
VERSION		= 2
RELEASE		= 2


After copy pasting the upper params under ### START CHANGES ###, I ran the package.sh script to find:

Wrote: /home/mishaone/Desktop/Staging/Beta_Documentation/packager/en-US/tmp/rpm/SRPMS/JBoss_Enterprise_Data_Grid-Beta_Documentation-6-web-en-US-1-51.el5.src.rpm   <--- This is the correct name and version. \o/
Comment 1 Misha H. Ali 2011-10-28 01:27:07 UTC 
Priority set to high IF Skynet is going to be offered to other products soon. If this is not the case, please deprioritize, Matt.
Comment 2 Matthew Casperson 2011-11-03 01:40:04 UTC 
The Makefile template should have had the lines:

### START CHANGES ###
PRODUCT  = JBoss_Enterprise_Application_Platform  <--- Back to EAP. 
PROD_VERSION = 6
LANG  = en-US
BOOKS  = Beta_Documentation
VERSION  = 2
RELEASE  = 2

removed. This how now been done.