Bug 749874
Summary: | Please build for EPEL 6 | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jonathan Underwood <jonathan.underwood> |
Component: | ctpl | Assignee: | Dominic Hopf <dmaphy> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | dmaphy |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | ctpl-0.3.2-4.el6 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-01-05 20:31:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jonathan Underwood
2011-10-28 18:40:54 UTC
Of course. Requested el6 branch with #615091. :) Hi Jonathan, the scratch-builds I tried this morning unfortunately failed. I just noticed in koji you most likely already saw this. I'm a bit confused about the man page issue and run out of ideas what the cause for this build failure could be. Do you have any idea what may could cause this? Regs, Dom Yes, I just noticed this as well, and can't quite work out why it's failing either. It looks like the man page simply isn't being installed during %install. Will have a look more closely later. OK, the reason is this. During configure we see: configure: WARNING: The ctpl command-line utility will not be built because of the following error: Requested 'gio-2.0 >= 2.24' but version of GIO is 2.22.5 So, the command line ctpl isn't built. Looking at the Makefile.am in the data directory, in this case the man page isn't installed either. I suppose this makes sense - no need to install a man page for a command line tool that isn't installed. So, the question is: is this package useful without the ctpl command line tool? And does the geany-plugins package need that command line tool? Just talked back to Colomban (the upstream developer) to make sure I'm not telling something wrong. The ctpl command line tool is not needed to run GeanyGenDoc - which is in fact the only plugin which makes use of the library ctpl provides as well. There is no support for disabling the build of the CLI tool, yet. Thus we would have to remove the CLI stuff from the package? The main CTPL package would more or less become some kind of meta package then, wouldn't it? Well, Colomban was quite fast with adding some build features: http://git.tuxfamily.org/ctpl/ctpl/?p=gitroot/ctpl/ctpl.git;a=commitdiff;h=fdf8e8a8e5a190ff03aefbd9dc80bcc083a2854b :) If he's a responsive maintainer it might be worth asking him if he would add support for gio 2.22.5 since that's going to be on production systems for a long time to come (it being in RHEL 6) - it would be worth finding out what is the reason for requiring gio 2.24. The reason for the requirement to Gio 2.24 is GCharsetConverter. Colomban mentioned two possible ways to drop or rather reduce this requirement: 1) remove charset support (bad, wouldn't be CTPL 0.3) 2) include a copy of GCharsetConverter 1) wouldn't be an option I guess, and he won't do 2) upstream, but we maybe could do it in the package. So if I see this right there are two possibilities to get the support for GeanyGenDoc, either we resign the CTPL command line utility, or we ship an own copy of GCharsetConverter. I tend to suggest the copy of GCharsetConverter, what do you think? Yes, I agree - adding a patch to the package to add in GCharsetConverter would be the best option if it's not too tricky to do. Will try and look at it tomorrow, but maybe you and/or Colomban will beat me to it :) Here is a try to do this: http://dmaphy.fedorapeople.org/ctpl/ctpl-0.3.2-4.el6.src.rpm The build unfortunately fails with: gcharsetconverter.h:24:2: error: #error "Only <gio/gio.h> can be included directly." gcharsetconverter.h:30:28: error: gio/gconverter.h: No such file or directory In file included from ctpl.c:34: This would mean we would have to extract more or less the whole Gio stuff from glib2 and ship it with ctpl. Not sure if that still would fit with the guidelines. :s Just to keep you up-to-date: I won't get around to continue on this until beginning of next week. ctpl-0.3.2-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ctpl-0.3.2-4.el6 ctpl-0.3.2-4.el6 has been pushed to the Fedora EPEL 6 testing repository. ctpl-0.3.2-4.el6 has been pushed to the Fedora EPEL 6 stable repository. |