Bug 750383

Summary: delegates.xml not up to date, especially with mpeg
Product: [Fedora] Fedora Reporter: Orion Poplawski <orion>
Component: ImageMagickAssignee: Pavel Alexeev <pahan>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 15CC: nmurray, pahan
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: ImageMagick-6.7.0.10-4.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-02 06:22:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Orion Poplawski 2011-10-31 22:07:29 UTC
Description of problem:

It appears that config/delegates.xml.in is not really in sync with www/source/delegates.xml and some fixes in the latter are not in the former.  In particular, mpeg.

ImageMagick-6.7.1-9/www/source/delegates.xml:
  <delegate decode="mpeg:decode" command="&quot;ffmpeg&quot; -v -1 -i &quot;%i&quot; -vcodec pam -an -f rawvideo -y &quot;%u0.pam&quot; 2&gt; &quot;%Z&quot;"/>
  <delegate encode="mpeg:encode" stealth="True" command="&quot;ffmpeg&quot; -v -1 -i &quot;%M%%d.jpg&quot; &quot;%u.%m&quot; 2&gt; &quot;%Z&quot;"/>

ImageMagick-6.7.1-9/config/delegates.xml.in:
  <delegate decode="mpeg:decode" command="&quot;@MPEGDecodeDelegate@&quot; -v -1 -vframes %S -i &quot;%i&quot; -vcodec pam -an -f rawvideo -y &quot;%u.pam&quot; 2&gt; &quot;%Z&quot;"/>
  <delegate encode="mpeg:encode" stealth="True" command="&quot;@MPEGEncodeDelegate@&quot; -v -1 -mbd rd -trellis 2 -cmp 2 -subcmp 2 -g 300 -pass 1/2 -i &quot;%M%%d.jpg&quot; &quot;%u.%m&quot; 2&gt; &quot;%Z&quot;"/>

In Fedora 15+ ffmpeg croaks with the -pass 1/2 argument.  Works fine when using the command from the delegates.xml file or when simply removing the -pass 1/2 option.  It may be that the www/source/delegates.xml file is quite old as well and not the preferred method.

Version-Release number of selected component (if applicable):
ImageMagick-6.7.0.10-3.fc16
ImageMagick-6.6.5.10-19.fc15

Steps to Reproduce:
1. convert *.jpg output.mpg
  
Actual results:
convert: delegate failed `"ffmpeg" -v -1 -mbd rd -trellis 2 -cmp 2 -subcmp 2 -g 300 -pass 1/2 -i "%M%%d.jpg" "%u.%m" 2> "%Z"' @ error/delegate.c/InvokeDelegate/1058.

Comment 1 Pavel Alexeev 2011-11-02 06:22:10 UTC
Thank you for your bugreport and willing make free software better!

Reported upstream: http://www.imagemagick.org/discourse-server/viewtopic.php?f=3&t=19755

We close bug now, as it related to upstream developing. But we continue track changes and whatever it will be fixed ve consider make update in Fedora.

Comment 2 Pavel Alexeev 2011-11-02 12:46:23 UTC
Its fixed upstream. In next update build it come in Fedora.

Comment 3 Orion Poplawski 2011-11-02 14:35:12 UTC
Can this get fixed in F15 please?

Comment 4 Pavel Alexeev 2011-11-02 14:57:21 UTC
No, only in rawhide if you wish.

It is not sewcurity bug and ImageMagick have many dependencies for rebuilt.

Comment 5 Orion Poplawski 2011-11-02 15:02:05 UTC
There is no need to update the version of ImageMagick, just backport the change to delegates.xml.in.  I'm a proven packager and could do it if you'd like.

Comment 6 Pavel Alexeev 2011-11-02 16:59:26 UTC
You suggest made backport temporary patch? I do not see any real advantages for that...
There at least ryby-rmagick what have full versioned dependency, may be others due to the discussed before not wery accurate soname bump by upstream. So, if you provenpackager and you really want it - you may create ticket and request separate tag to build such dependencies... But again, I think it have no worth.

Comment 7 Orion Poplawski 2011-11-02 17:37:24 UTC
Again, there is no need to bump the version number, just the release (which nobody AFAICT explicitly depends on).

diff --git a/ImageMagick.spec b/ImageMagick.spec
index 2f27474..570c007 100644
--- a/ImageMagick.spec
+++ b/ImageMagick.spec
@@ -3,13 +3,15 @@
 
 Name:           ImageMagick
 Version:        %{VER}.%{Patchlevel}
-Release:        3%{?dist}
+Release:        4%{?dist}
 Summary:        An X application for displaying and manipulating images
 Group:          Applications/Multimedia
 License:        ImageMagick
 Url:            http://www.imagemagick.org/
 Source0:        ftp://ftp.ImageMagick.org/pub/%{name}/%{name}-%{VER}-%{Patchlevel}.tar.xz
 Patch1:         ImageMagick-6.4.0-multilib.patch
+#Upstream patch for ffmpeg support
+Patch2:         ImageMagick-delegates.patch
 
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires:  bzip2-devel, freetype-devel, libjpeg-devel, libpng-devel
@@ -128,6 +130,7 @@ however.
 %prep
 %setup -q -n %{name}-%{VER}-%{Patchlevel}
 %patch1 -p1 -b .multilib
+%patch2 -p0 -b .delegates
 sed -i 's/libltdl.la/libltdl.so/g' configure
 iconv -f ISO-8859-1 -t UTF-8 README.txt > README.txt.tmp
 touch -r README.txt README.txt.tmp
@@ -303,6 +306,9 @@ rm -rf $RPM_BUILD_ROOT
 
 
 %changelog
+* Wed Nov 2 2011 Orion Poplawski <orion.com> - 6.7.0.10-4
+- Patch delegates.xml for ffmpeg (bug #750383)
+
 * Thu Jul 21 2011 Petr Sabata <contyk> - 6.7.0.10-3
 - Perl mass rebuild
 
Shouldn't require any other rebuilds.

Comment 8 Fedora Update System 2011-11-03 16:32:28 UTC
ImageMagick-6.6.5.10-20.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/ImageMagick-6.6.5.10-20.fc15

Comment 9 Fedora Update System 2011-11-03 16:32:36 UTC
ImageMagick-6.7.0.10-4.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/ImageMagick-6.7.0.10-4.fc16

Comment 10 Fedora Update System 2011-11-03 16:32:43 UTC
ImageMagick-6.6.4.1-16.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/ImageMagick-6.6.4.1-16.fc14

Comment 11 Fedora Update System 2011-11-19 23:30:31 UTC
ImageMagick-6.6.4.1-16.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2011-11-19 23:33:04 UTC
ImageMagick-6.6.5.10-20.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2011-11-19 23:34:15 UTC
ImageMagick-6.7.0.10-4.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.