Bug 750489

Summary: Forward null defect found by Coverity (iscsi-initiator-utils)
Product: Red Hat Enterprise Linux 6 Reporter: Pavel Raiskup <praiskup>
Component: iscsi-initiator-utilsAssignee: Andy Grover <agrover>
Status: CLOSED DUPLICATE QA Contact: Storage QE <storage-qe>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.3CC: bdonahue, coughlan, czhang, mchristi
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 723185 Environment:
Last Closed: 2012-04-05 21:08:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 767187    

Description Pavel Raiskup 2011-11-01 10:14:12 UTC 
=> open-iscsi-2.0-872-rc4-bnx2i/usr/discovery.c:869

Null dereference of variable iface.

This is a clone of bug 723185.

Coverity says:

Error: FORWARD_NULL:
/builddir/build/BUILD/open-iscsi-2.0-872-rc4-bnx2i/usr/discovery.c:852: var_compare_op: Comparing "iface" to null implies that "iface" might be null.
/builddir/build/BUILD/open-iscsi-2.0-872-rc4-bnx2i/usr/discovery.c:869: var_deref_model: Passing null variable "iface" to function "iface_copy", which dereferences it.
/builddir/build/BUILD/open-iscsi-2.0-872-rc4-bnx2i/usr/iface.c:533: deref_parm_field_in_call: Function "strlen" dereferences field "src->name". (The dereference is assumed on the basis of the 'nonnull' parameter attribute.)
Comment 2 Mike Christie 2012-03-20 20:54:00 UTC 
It will be ok to push this to 6.4.
Comment 3 Mike Christie 2012-04-05 21:08:35 UTC 

*** This bug has been marked as a duplicate of bug 810197 ***