Bug 750527

Summary: Tab order differs on different platforms
Product: [Fedora] Fedora Reporter: Kamil Páral <kparal>
Component: firstbootAssignee: Martin Gracik <mgracik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 16CC: bcl, dmach, jskladan, mgracik
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-17 12:29:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
32b firstboot
none
64b firsboot none

Description Kamil Páral 2011-11-01 13:39:01 UTC 
Description of problem:
i686 version of firstboot has tabs in a different order than x86_64 version of firstboot. The tabs "Date and Time" and "Create User" are swapped. See screenshots.

I don't think that's intentional and I believe the UI should look the same regardless of platform.

Version-Release number of selected component (if applicable):
firstboot-16.4-1.fc16.i686
firstboot-16.4-1.fc16.x86_64
Comment 1 Kamil Páral 2011-11-01 13:39:35 UTC 
Created attachment 531132 [details]
32b firstboot
Comment 2 Kamil Páral 2011-11-01 13:40:01 UTC 
Created attachment 531133 [details]
64b firsboot
Comment 3 Josef Skladanka 2011-11-01 14:18:50 UTC 
IMHO the problem caused by the fact, that firstboot modules create_user.py and date.py have the same priority.

Next, even though the comment in firstboot/module.py says, that all modules with the same priority are sorted alphabeticaly, it is IMHO not true, because the fistboot/loader.py reads the modules from hard drive (which means in order according to their inode, not alphabeticaly) @line 62, and then the list of 'successfully loaded' modules is sorted just by the priority @line 112.

These two combined IMHO cause the fact that the 32b firstboot and 64b firstboot have different order of modules.
Comment 4 Kamil Páral 2011-11-01 14:27:36 UTC 
OK, so the bug is in inode order, so it can manifest itself even with two different installations on the same architecture.

BTW, I believe there is no reason to have two modules with the same priority and sort them then according to alphabet, which gives different results for different languages. It seems like a bad idea to me. Use different priorities for all the modules so that it looks the same regardless of inode order and regardless of localization.