| Summary: | Introduced dependency on tomcat-dbcp | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | David G. Mackay <mackay_d> |
| Component: | tomcat6 | Assignee: | David Knox <dknox> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | tomcat-qe |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.0 | CC: | jclere, jdennis, jpechane |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-01-26 19:16:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
David G. Mackay
2011-11-01 14:53:53 UTC
This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unfortunately unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. If you would like it considered as an exception in the current release, please ask your support representative. The reason that I turned this in as a bug is that the dependency on tomcat-dbcp should be removed, in my opinion. Installing tomcat-dbcp is a temporary fix. If you're not going to include tomcat-dbcp.jar, then this IS a bug. This is related to: rhbz 217630, 217141, & 669969. It is a configuration issue.
tomcat-jdbc.jar is a conglomeration of commons-collections,
commons-dbcp, and commons-pool.The tomcat build changes one bit of code to prohibit the use of collections::UnmodifiableList. It changes the package
name to o.a.t.dbcp.dbcp.*, compiles, and rejars into tomcat-jdbc. RHEL packaging for tomcat5 and tomcat6, as well as Fedora packaging, do not fire that target. The org.apache.commons.dbcp.BasicDataSourceFactory (from commons-dbcp) is the same class as org.apache.tomcat.dbcp.dbcp.BasicDataSourceFactory (from tomcat-dbcp-dbcp).The dependencies (the Requires and BuildRequires) on commons-xxx-tomcat5 do not exist in the spec file. Nevertheless, Tomcat internals assume org.apache.tomcat.dbcp.dbcp.BasicDataSourceFactory as the default if the j2ee configuration of the DataSource.Factory does not exist.
Using the javax.sql.DataSource.Factory j2ee property to define the
BasicDataSourceFactory should fix the problem permenently. You don't need to use the factory attribute in your web.xml.
The configuration was introduced in tomcat6.conf for tomcat6-6.0.24-29.el6 and tomcat6-6.0.24-34.el6_1. /etc/tomcat6/tomcat6.conf already contains:
JAVA_OPTS="${JAVA_OPTS} -Djavax.sql.DataSource.Factory=org.apache.commons.dbcp.BasicDataSourceFactory"
Since the current release contains the correct configuration, I'm closing this with CURRENTRELEASE
|