| Summary: | Review Request: uhd - universal HW driver for Ettus Research products (i.e. HW for gnuradio) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jaroslav Škarvada <jskarvad> |
| Component: | Package Review | Assignee: | Jan Kaluža <jkaluza> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jkaluza, notting, package-review |
| Target Milestone: | --- | Flags: | jkaluza:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-01 16:17:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Jaroslav Škarvada
2011-11-01 17:01:04 UTC
[!] rpmplint is silent uhd.x86_64: W: spelling-error %description -l en_US gnuradio -> gnu radio, gnu-radio, radiogram uhd.x86_64: W: no-documentation uhd-devel.x86_64: W: no-documentation uhd-devel.x86_64: W: no-manual-page-for-binary uhd_find_devices uhd-devel.x86_64: W: no-manual-page-for-binary uhd_usrp_probe 3 packages and 0 specfiles checked; 0 errors, 5 warnings. It looks they call it "GNU Radio" officialy. It's not big problem, but it fixes the warning imho. For no-documentation, check "License file is present..." below. uhd.src: W: spelling-error %description -l en_US gnuradio -> gnu radio, gnu-radio, radiogram uhd.src: W: invalid-url Source0: uhd-3.3.0.tar.gz That's OK, since upstream doesn't provide useful tarball. [YES] Package meets naming guidelines. [YES] Package meets packaging guidelines. [YES] Spec file matches base package name. [NO] License file is present, matching with spec file. http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text There's license file installed in -doc subpackage, so I presume it could be installed also in the main uhd package according to guidelines. [YES] Licensing Guidelines are met. [YES] Spec file is legible and in American English. [YES] Sources match upstream. You should use tag instead of revision hash to make it clearer you're using proper version. Just replace git hash with release_003_003_000. You can list all tags using "git tag". [YES] Package builds OK. [YES] BuildRequires are correct. [YES] Package doesn't bundle copies of system libraries. [YES] Package owns all the directories it creates. [YES] Package has no duplicity in %files. [YES] Permission on files are set properly. [YES] Package is code or permissible content. [YES] %doc files don't affect runtime. [YES] Package doesn't own files/directories that other packages own. [YES] All files are valid UTF-8. Should items: [YES] Package builds in mock. [YES] Package uses sane scriptlets. [NO] Package contains man pages. [YES] Very simple functionality test passed. Thanks for the review. Hopefully I fixed it all: Spec URL: http://jskarvad.fedorapeople.org/gnuradio/uhd.spec SRPM URL: http://jskarvad.fedorapeople.org/gnuradio/uhd-3.3.0-2.fc14.src.rpm > It looks they call it "GNU Radio" officialy. It's not big problem, but it fixes the warning imho. > I took the description from the upstream, but no problem to fix. > There's license file installed in -doc subpackage, so I presume it could be installed also in the main uhd package according to guidelines. > Basic docs (including license) were moved to base package. > You should use tag instead of revision hash to make it clearer you're using proper version. Just replace git hash with release_003_003_000. > Just comments, but fixed. I also removed defattrs, switched to macros style instead of variables and I moved the binaries to base backage from devel. I think everything is OK now. Setting the fedora-review flag to +. New Package SCM Request ======================= Package Name: uhd Short Description: Universal Hardware Driver for Ettus Research products Owners: jskarvad Branches: f16 InitialCC: jkaluza Git done (by process-git-requests). Package Change Request ====================== Package Name: uhd New Branches: epel7 Owners: jskarvad InitialCC: Git done (by process-git-requests). |