Bug 750701

Summary: ValueError: invalid target size request
Product: [Fedora] Fedora Reporter: Hongqing Yang <hoyang>
Component: anacondaAssignee: David Lehman <dlehman>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 16CC: djuran, jonathan, vanmeeuwen+fedora
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: abrt_hash:d8e7613ca5245c95ab78c3a3f72373aefe40dcb031b59c68d5daac0550ed244f
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-05-14 08:59:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
File: anaconda-tb-PFBrTV
none
shrink screenshot none

Description Hongqing Yang 2011-11-02 05:08:06 UTC
libreport version: 2.0.6
executable:     /usr/bin/python
hashmarkername: anaconda
kernel:         3.1.0-7.fc16.x86_64
product:        Fedora
reason:         ValueError: invalid target size request
time:           Wed Nov  2 01:10:26 2011
version:        16

anaconda-tb-PFBrTV: Text file, 288552 bytes

description:
:The following was filed automatically by anaconda:
:anaconda 16.24 exception report
:Traceback (most recent call first):
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/formats/fs.py", line 202, in _setTargetSize
:    raise ValueError("invalid target size request")
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/deviceaction.py", line 548, in __init__
:    self.device.format.targetSize = newsize
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/partitioning.py", line 237, in scheduleShrinkActions
:    storage.devicetree.registerAction(ActionResizeFormat(device, size))
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/partitioning.py", line 258, in doAutoPartition
:    scheduleShrinkActions(anaconda.storage)
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/dispatch.py", line 373, in dispatch
:    self.dir = self.steps[self.step].target(self.anaconda)
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/dispatch.py", line 241, in go_forward
:    self.dispatch()
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/gui.py", line 1201, in nextClicked
:    self.anaconda.dispatch.go_forward()
:ValueError: invalid target size request

Comment 1 Hongqing Yang 2011-11-02 05:08:11 UTC
Created attachment 531245 [details]
File: anaconda-tb-PFBrTV

Comment 2 Hongqing Yang 2011-11-02 05:11:54 UTC
This is caused by giving small size of disk to the current system.
I would be better to detect the smallest size required by the disk of  the current system rather than to give error.

Comment 3 Hongqing Yang 2011-11-03 11:53:14 UTC
bug description:

when shrink the disk with the default disk size value or smaller value. This will occur. It seems and anaconda cannot check the required disk size for the system.

Comment 4 David Lehman 2011-11-03 13:52:13 UTC
I tried, but was unable to set a value lower than the minimum/default. How are you doing this?

Comment 5 Hongqing Yang 2011-11-04 08:47:15 UTC
Created attachment 531724 [details]
shrink screenshot

I got this error sometimes.
You can find from the attachment screenshot, the default disk size is 2315, when I click 'shrink', the error occurs.
If I choose a lower size, it will be resized to 2315, the error occurs,too.
If a bigger size is set, that will be fine.

Comment 6 Hongqing Yang 2012-02-03 06:01:35 UTC
This is reproduced with anaconda 16.25. 
I think this is caused by the low size of disk. but anaconda does not give 
the proper error information.

Comment 7 David Lehman 2012-02-03 14:11:50 UTC
In spite of the time stamps, the following log entries are presented in their original order:

05:07:46,487 INFO program: Running... resize2fs -P /dev/sda3
05:07:46,500 INFO program: Estimated minimum size of the filesystem: 643161


05:07:48,090 INFO program: Running... /bin/mount -n -t ext4 -o ro /dev/sda3 /mnt/sysimage
05:08:14,509 INFO program: Running... /bin/umount /mnt/sysimage


01:08:48,913 INFO program: Running... resize2fs -P /dev/sda3
01:08:48,924 INFO program: Estimated minimum size of the filesystem: 644943

So the read-only mount we do is changing the number of free blocks in the filesystem, which invalidates our minimum size for this filesystem.

Comment 8 David Lehman 2012-02-03 14:16:14 UTC
This is probably caused by the filesystem not being unmounted cleanly just prior to installation. The read-only mount does some clean-up that should have been done on the previous unmount, changing the block size. Can you confirm or deny the correlation between not cleanly unmounting the filesystem right before install and this error?

Comment 9 Hongqing Yang 2012-05-14 08:59:04 UTC
I would like to close this since the bug is not reproduced with the current release--Fedora 17 Final TC5.