Bug 750898
Summary: | Review Request: icaro - A robot automation language | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Larry Letelier <geek> | ||||
Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> | ||||
Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | rawhide | CC: | echevemaster, geek, guillermo.gomez, lemenkov, notting, package-review, rc040203 | ||||
Target Milestone: | --- | Flags: | lemenkov:
fedora-review?
|
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2013-02-20 02:30:44 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Larry Letelier
2011-11-02 18:12:49 UTC
Changes & updates: SPEC url: http://lletelier.fedorapeople.org/icaro/icaro.spec SRPM url: http://lletelier.fedorapeople.org/icaro/icaro-0.6.3-140811.fc15.src.rpm RPM x86_64 url: http://lletelier.fedorapeople.org/icaro/icaro-0.6.3-140811.fc15.x86_64.rpm rpmlint: http://lletelier.fedorapeople.org/icaro/icaro-0.6.3-140811.txt Thanks, --LL I'll review it (and will sponsor you). Thanks Peter, -- LL Created attachment 569080 [details]
adds missing include header
Few notes. * The package fails to build on non-x86 arches due to lack of <sys/io.h>. Please add "ExclusiveArch: %{ix86} x86_64" for now. I think it's a good idea to add check for this and for some other required files to the configure.ac but that's not related to the packaging and won't block the review process - that's just my friendly advice. * The package fails to build due to the missing include file - <unistd.h>. Please see patch attached. http://koji.fedoraproject.org/koji/taskinfo?taskID=3877160 Btw what's your FAS name? (In reply to comment #2) > I'll review it (and will sponsor you). AFAIK LL is already sponsored, he just need to be reviewed. 2 nits: * %release is poorly chosen. It needs to contain a fedora specific release number. You are trying to reuse some upstream release number, which doesn't leave the fedora package maintainer an option to increment it. * Please move the "chmod -x" from %build into %prep. *** This bug has been marked as a duplicate of bug 912930 *** |