Bug 750933

Summary:	Preserve metadata is not functioning on re-sync if source modifies content
Product:	[Retired] Pulp	Reporter:	John Matthews <jmatthew>
Component:	user-experience	Assignee:	Pradeep Kilambi <pkilambi>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Preethi Thomas <pthomas>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	kbidarka, pkilambi, sghai, tsanders
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	750932	Environment:
Last Closed:	2012-02-24 20:12:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	750932
Bug Blocks:

Description John Matthews 2011-11-02 21:11:09 UTC

+++ This bug was initially created as a clone of Bug #750932 +++

Description of problem:


Scenario is:
1) Initial sync is successful, preserve metadata works
2) Source repo makes some changes, say an errata is deleted
3) Pulp performs a resync
 a) sees errata is deleted or package is removed
 b) createrepo is triggered

Log example below.
I confirmed that this repo was marked as "preserve_metadata":true from mongo.


2011-10-31 14:20:37,782 5129:139946610390784: pulp.server.util:ERROR: util:404 createrepo on /var/lib/pulp//repos/content/dist/rhel/rhui/server/5/5Server/x86_64/os failed
2011-10-31 14:20:37,816 5129:139946610390784: pulp.server.api.synchronizers:ERROR: synchronizers:369 sh: line 1: 16279 Killed                  createrepo --database --checksum sha256 -g /var/lib/pulp//repos/content/dist/rhel/rhui/server/5/5Server/x86_64/os/repodata/87b78cae8caf76f232374d6a8f8392b8c7fb0239-comps-rhel-x86_64-server-5.xml --update /var/lib/pulp//repos/content/dist/rhel/rhui/server/5/5Server/x86_64/os
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/pulp/server/api/synchronizers.py", line 363, in sync_updateinfo_data
    repo_api.delete_erratum(repo['id'], e['id'])
  File "/usr/lib/python2.6/site-packages/pulp/server/api/repo.py", line 1073, in delete_erratum
    self._update_errata_packages(repoid, [erratumid], action='delete')
  File "/usr/lib/python2.6/site-packages/pulp/server/api/repo.py", line 1044, in _update_errata_packages
    self.remove_packages(repo['id'], rmids)
  File "/usr/lib/python2.6/site-packages/pulp/server/api/repo.py", line 963, in remove_packages
    pulp.server.util.create_repo(repo_path, checksum_type=repo["checksum_type"])
  File "/usr/lib/python2.6/site-packages/pulp/server/util.py", line 421, in create_repo
    _create_repo(dir, groups=groups, checksum_type=checksum_type)
  File "/usr/lib/python2.6/site-packages/pulp/server/util.py", line 405, in _create_repo
    raise CreateRepoError(out)
CreateRepoError: sh: line 1: 16279 Killed                  createrepo --database --checksum sha256 -g /var/lib/pulp//repos/content/dist/rhel/rhui/server/5/5Server/x86_64/os/repodata/87b78cae8caf76f232374d6a8f8392b8c7fb0239-comps-rhel-x86_64-server-5.xml --update /var/lib/pulp//repos/content/dist/rhel/rhui/server/5/5Server/x86_64/os

Comment 1 Pradeep Kilambi 2011-11-03 14:19:47 UTC

cherry-pick'ed to rhui from master:

commit 7db220abfbd9aaedc6c018c7fd611b2794d195f8

commit 85e71183be14ccf5b0e533396591c2fa79223b1f

Comment 2 Jay Dobies 2011-11-09 20:32:08 UTC

Fixed in build 0.247.

Comment 3 Preethi Thomas 2012-01-09 14:32:20 UTC

verified in 0.256

[root@preethi ~]# pulp-admin repo sync --id=rhel6_x86_64_preserve -F
Sync for repository rhel6_x86_64_preserve started
Sync: Finished
4/6710 new items downloaded
6706/6710 existing items processed

Item Details: 
RPMs: 6710/6710

[root@preethi ~]# pulp-admin repo info --id=rhel6_x86_64_preserve 

Id                 	rhel6_x86_64_preserve    
Name               	rhel6_x86_64_preserve    
Repo URL           	https://preethi.usersys.redhat.com/pulp/repos/content/dist/rhel/rhui/server-6/updates/6Server/x86_64/os/
Feed URL           	https://cdn.redhat.com/content/dist/rhel/rhui/server-6/updates/6Server/x86_64/os/
Feed Type          	remote                   
Content Type       	yum                      
Feed Certs         	CA:Yes   Cert:Yes
Consumer Certs     	CA:No   Cert:No
Architecture       	noarch                   
Sync Schedule      	None                     
Packages           	6710                     
Files              	0                        
Distributions      	None                     
Publish            	True                     
Clones             	[]                       
Groups             	None                     
Filters            	[]                       
Notes              	{}                       
Preserve Metadata  	True                     
Checksum Type      	sha256

Comment 4 Preethi Thomas 2012-02-24 20:12:29 UTC

Pulp v1.0 is released
Closed Current Release.